Skip to content

*: fix the max recv message size for the client#1952

Merged
sre-bot merged 1 commit intotikv:release-3.0from
rleungx:fix-grpc-message
Nov 19, 2019
Merged

*: fix the max recv message size for the client#1952
sre-bot merged 1 commit intotikv:release-3.0from
rleungx:fix-grpc-message

Conversation

@rleungx
Copy link
Copy Markdown
Member

@rleungx rleungx commented Nov 18, 2019

What problem does this PR solve?

PR #1739 accidentally removes the max gRPC receive message size constraint for the client.

What is changed and how it works?

This PR fixes it by adding it back.

Check List

Tests

  • Unit test

Related changes

  • Need to be included in the release notes

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added the type/bug The issue is confirmed as a bug. label Nov 18, 2019
@rleungx rleungx requested review from lhy1024 and nolouch November 18, 2019 13:05
@rleungx
Copy link
Copy Markdown
Member Author

rleungx commented Nov 18, 2019

/run-all-tests

@lhy1024
Copy link
Copy Markdown
Contributor

lhy1024 commented Nov 19, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 19, 2019
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Nov 19, 2019

/run-all-tests

@sre-bot sre-bot merged commit 7a5909e into tikv:release-3.0 Nov 19, 2019
rleungx added a commit to rleungx/pd that referenced this pull request Nov 25, 2019
Signed-off-by: Ryan Leung <rleungx@gmail.com>
nolouch pushed a commit that referenced this pull request Nov 25, 2019
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. type/bug The issue is confirmed as a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants