Skip to content

*: fix the issue that loadcluster does not remove overlap regions(#2022) (#2039)#2040

Merged
sre-bot merged 1 commit intotikv:release-3.0from
sre-bot:release-3.0-ce91ee946799
Dec 19, 2019
Merged

*: fix the issue that loadcluster does not remove overlap regions(#2022) (#2039)#2040
sre-bot merged 1 commit intotikv:release-3.0from
sre-bot:release-3.0-ce91ee946799

Conversation

@sre-bot
Copy link
Copy Markdown
Contributor

@sre-bot sre-bot commented Dec 19, 2019

cherry-pick #2039 to release-3.0


Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

cherry-pick #2022

What is changed and how it works?

cherry-pick.

Check List

Tests

  • Unit test

@nolouch
Copy link
Copy Markdown
Contributor

nolouch commented Dec 19, 2019

/run-all-tests

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2040 into release-3.0 will increase coverage by 0.23%.
The diff coverage is 91.17%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.0    #2040      +/-   ##
===============================================
+ Coverage        69.43%   69.67%   +0.23%     
===============================================
  Files              170      170              
  Lines            16769    16787      +18     
===============================================
+ Hits             11644    11696      +52     
+ Misses            4145     4122      -23     
+ Partials           980      969      -11
Impacted Files Coverage Δ
server/handler.go 51.87% <ø> (+0.25%) ⬆️
server/core/errors.go 62.5% <100%> (+12.5%) ⬆️
server/core/region_kv.go 82.95% <100%> (+1.13%) ⬆️
server/core/kv.go 77.53% <100%> (+1.44%) ⬆️
server/core/region.go 93.5% <100%> (+0.02%) ⬆️
server/core/basic_cluster.go 93.1% <83.33%> (-2.55%) ⬇️
server/cluster_info.go 88.07% <92.3%> (+0.09%) ⬆️
pkg/tempurl/tempurl.go 57.14% <0%> (-14.29%) ⬇️
server/grpc_service.go 58.63% <0%> (+0.42%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c97ed...41a5076. Read the comment docs.

@nolouch
Copy link
Copy Markdown
Contributor

nolouch commented Dec 19, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 19, 2019
@sre-bot
Copy link
Copy Markdown
Contributor Author

sre-bot commented Dec 19, 2019

/run-all-tests

@sre-bot sre-bot merged commit 4fea0f0 into tikv:release-3.0 Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants