Modify method parameters and return values (#10288)

sourcelliu · jackysp · commit 52e67447fbd2 · 2019-04-30T14:59:05.000+08:00
diff --git a/plugin/conn_ip_example/conn_ip_example.go b/plugin/conn_ip_example/conn_ip_example.go
@@ -41,9 +41,9 @@ func OnShutdown(ctx context.Context, manifest *plugin.Manifest) error {
 }
 
 // OnGeneralEvent implements TiDB Audit plugin's OnGeneralEvent SPI.
-func OnGeneralEvent(ctx context.Context, sctx *variable.SessionVars, event plugin.GeneralEvent, cmd byte, stmt string) error {
+func OnGeneralEvent(ctx context.Context, sctx *variable.SessionVars, event plugin.GeneralEvent, cmd string) {
 	fmt.Println("conn_ip_example notifiy called")
 	fmt.Println("variable test: ", variable.GetSysVar("conn_ip_example_test_variable").Value)
 	fmt.Printf("new connection by %s\n", ctx.Value("ip"))
-	return nil
+	return
 }

Original file line number	Diff line number	Diff line change
`@@ -41,9 +41,9 @@ func OnShutdown(ctx context.Context, manifest *plugin.Manifest) error {`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`// OnGeneralEvent implements TiDB Audit plugin's OnGeneralEvent SPI.`
`44`		`-func OnGeneralEvent(ctx context.Context, sctx *variable.SessionVars, event plugin.GeneralEvent, cmd byte, stmt string) error {`
	`44`	`+func OnGeneralEvent(ctx context.Context, sctx *variable.SessionVars, event plugin.GeneralEvent, cmd string) {`
`45`	`45`	`fmt.Println("conn_ip_example notifiy called")`
`46`	`46`	`fmt.Println("variable test: ", variable.GetSysVar("conn_ip_example_test_variable").Value)`
`47`	`47`	`fmt.Printf("new connection by %s\n", ctx.Value("ip"))`
`48`		`- return nil`
	`48`	`+ return`
`49`	`49`	`}`