binlog: fix the wrong fatal error when binlog is too large (#46365) (#46380)

ti-chi-bot · web-flow · commit 89ba2e70f651 · 2023-10-17T04:15:28.000Z
close #28659
diff --git a/sessionctx/binloginfo/binloginfo.go b/sessionctx/binloginfo/binloginfo.go
@@ -269,7 +269,7 @@ func (info *BinlogInfo) WriteBinlog(clusterID uint64) *WriteResult {
 			return &WriteResult{true, nil}
 		}
 
-		if strings.Contains(err.Error(), "received message larger than max") {
+		if strings.Contains(err.Error(), "message larger than max") {
 			// This kind of error is not critical, return directly.
 			return &WriteResult{false, errors.Errorf("binlog data is too large (%s)", err.Error())}
 		}

Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ func (info BinlogInfo) WriteBinlog(clusterID uint64) WriteResult {`
`269`	`269`	`return &WriteResult{true, nil}`
`270`	`270`	`}`
`271`	`271`
`272`		`- if strings.Contains(err.Error(), "received message larger than max") {`
	`272`	`+ if strings.Contains(err.Error(), "message larger than max") {`
`273`	`273`	`// This kind of error is not critical, return directly.`
`274`	`274`	`return &WriteResult{false, errors.Errorf("binlog data is too large (%s)", err.Error())}`
`275`	`275`	`}`