Skip to content

test: remove dup comments#45711

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
Defined2014:Defined2014-patch-1
Aug 1, 2023
Merged

test: remove dup comments#45711
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
Defined2014:Defined2014-patch-1

Conversation

@Defined2014
Copy link
Copy Markdown
Contributor

@Defined2014 Defined2014 commented Aug 1, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2023
@tiprow
Copy link
Copy Markdown

tiprow bot commented Aug 1, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 1, 2023
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 1, 2023
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Aug 1, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-01 07:13:09.407338237 +0000 UTC m=+169473.349686768: ☑️ agreed by xhebox.
  • 2023-08-01 07:25:46.475436444 +0000 UTC m=+170230.417784974: ☑️ agreed by hawkingrei.

@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Aug 1, 2023
@Defined2014
Copy link
Copy Markdown
Contributor Author

Defined2014 commented Aug 1, 2023

/retest

@tiprow
Copy link
Copy Markdown

tiprow bot commented Aug 1, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 1, 2023 •
edited
Loading

Codecov Report

Merging #45711 (8f53280) into master (cf7ae4c) will increase coverage by 0.1861%.
Report is 2 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #45711        +/-   ##
================================================
+ Coverage   73.2076%   73.3938%   +0.1861%     
================================================
  Files          1266       1269         +3     
  Lines        390690     392548      +1858     
================================================
+ Hits         286015     288106      +2091     
+ Misses        86321      86122       -199     
+ Partials      18354      18320        -34
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.3856% <100.0000%> (+0.1779%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0467% <ø> (ø)
br 52.0053% <ø> (-0.0021%) ⬇️

@ti-chi-bot ti-chi-bot bot merged commit 67e8f90 into pingcap:master Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@xhebox xhebox xhebox approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Defined2014 @hawkingrei @xhebox
⚡