Improve test coverage

Author: ai

lib/autoprefixer.js

@@ -21,6 +21,7 @@ function timeCapsule(result, prefixes) {
         return;
     }
 
+    /* istanbul ignore next */
     result.warn(
         'Greetings, time traveller. ' +
         'We are in the golden age of prefix-less CSS, ' +

lib/hacks/break-props.js

@@ -12,12 +12,10 @@ class BreakProps extends Declaration {
      * Change name for -webkit- and -moz- prefix
      */
     prefixed(prop, prefix) {
-        if (prefix === '-webkit-') {
-            return `-webkit-column-${prop}`;
-        } else if (prefix === '-moz-') {
+        if (prefix === '-moz-') {
             return `page-${prop}`;
         } else {
-            return super.prefixed(prop, prefix);
+            return `${prefix}column-${prop}`;
         }
     }
 
@@ -29,20 +27,18 @@ class BreakProps extends Declaration {
             return 'break-inside';
         } else if (prop.indexOf('before') !== -1) {
             return 'break-before';
-        } else if (prop.indexOf('after') !== -1) {
+        } else {
             return 'break-after';
         }
-        return undefined;
     }
 
     /**
      * Change prefixed value for avoid-column and avoid-page
      */
     set(decl, prefix) {
-        const v = decl.value;
         if (decl.prop === 'break-inside' &&
-            v === 'avoid-column' ||
-            v === 'avoid-page'
+            decl.value === 'avoid-column' ||
+            decl.value === 'avoid-page'
         ) {
             decl.value = 'avoid';
         }

lib/hacks/display-flex.js

@@ -58,10 +58,8 @@ class DisplayFlex extends Value {
      */
     old(prefix) {
         const prefixed = this.prefixed(prefix);
-        if (prefixed) {
-            return new OldValue(this.name, prefixed);
-        }
-        return undefined;
+        if (!prefixed) return undefined;
+        return new OldValue(this.name, prefixed);
     }
 
 }

lib/hacks/filter-value.js

@@ -1,22 +1,4 @@
-const OldValue = require('../old-value');
 const Value = require('../value');
-const utils = require('../utils');
-
-class OldFilterValue extends OldValue {
-
-    /**
-     * Clean -webkit-filter from properties list
-     */
-    clean(decl) {
-        decl.value = utils.editList(decl.value, props => {
-            if (props.every(i => i.indexOf(this.unprefixed) !== 0)) {
-                return props;
-            }
-            return props.filter(i => i.indexOf(this.prefixed) === -1);
-        });
-    }
-
-}
 
 class FilterValue extends Value {
 
@@ -29,28 +11,6 @@ class FilterValue extends Value {
         }
     }
 
-    /**
-     * Use prefixed and unprefixed filter for WebKit
-     */
-    replace(value, prefix) {
-        if (prefix === '-webkit-' && value.indexOf('filter(') === -1) {
-            if (value.indexOf('-webkit-filter') === -1) {
-                return super.replace(value, prefix) + ', ' + value;
-            } else {
-                return value;
-            }
-        } else {
-            return super.replace(value, prefix);
-        }
-    }
-
-    /**
-     * Clean -webkit-filter
-     */
-    old(prefix) {
-        return new OldFilterValue(this.name, prefix + this.name);
-    }
-
 }
 
 module.exports = FilterValue;

lib/hacks/flex-values.js

@@ -89,9 +89,7 @@ class Gradient extends Value {
      * Normalize angle
      */
     normalize(nodes) {
-        if (!nodes[0]) {
-            return nodes;
-        }
+        if (!nodes[0]) return nodes;
 
         if (/-?\d+(.\d+)?grad/.test(nodes[0].value)) {
             nodes[0].value = this.normalizeUnit(nodes[0].value, 400);
@@ -159,7 +157,7 @@ class Gradient extends Value {
                 this.fixDirection(params);
             } else if (params[0].value.indexOf('deg') !== -1) {
                 this.fixAngle(params);
-            } else if (params[2].value === 'at') {
+            } else if (params[2] && params[2].value === 'at') {
                 this.fixRadial(params);
             }
         }
@@ -238,13 +236,11 @@ class Gradient extends Value {
         if (nodes[0] && nodes[0].value.indexOf('deg') !== -1) {
             return false;
         }
-        if (string.indexOf('px') !== -1) {
-            return false;
-        }
-        if (string.indexOf('-corner') !== -1) {
-            return false;
-        }
-        if (string.indexOf('-side') !== -1) {
+        if (
+            string.indexOf('px') !== -1 ||
+            string.indexOf('-corner') !== -1 ||
+            string.indexOf('-side') !== -1
+        ) {
             return false;
         }
 

lib/hacks/gradient.js

@@ -9,11 +9,9 @@ class GridArea extends Declaration {
      * Translate grid-area to separate -ms- prefixed properties
      */
     insert(decl, prefix, prefixes) {
-        if (prefix !== '-ms-') {
-            return super.insert(decl, prefix, prefixes);
-        }
+        if (prefix !== '-ms-') return super.insert(decl, prefix, prefixes);
 
-        if (!shorthand.isAlreadyApplied(decl, '-ms-grid-row')) {
+        if (decl.parent.some(i => i.prop === '-ms-grid-row')) {
             return undefined;
         }
 

lib/hacks/grid-area.js

@@ -25,11 +25,11 @@ class GridEnd extends Declaration {
      * Change property name for IE
      */
     prefixed(prop, prefix) {
+        let result = super.prefixed(prop, prefix);
         if (prefix === '-ms-') {
-            return prefix + prop.replace('-end', '-span');
-        } else {
-            return super.prefixed(prop, prefix);
+            result = result.replace('-end', '-span');
         }
+        return result;
     }
 
     /**

lib/hacks/grid-end.js

@@ -9,16 +9,9 @@ class GridRowColumn extends Declaration {
      * Translate grid-row / grid-column to separate -ms- prefixed properties
      */
     insert(decl, prefix, prefixes) {
-        if (prefix !== '-ms-') {
-            return super.insert(decl, prefix, prefixes);
-        }
-
-        if (!shorthand.isAlreadyApplied(decl, '-ms-' + decl.prop)) {
-            return undefined;
-        }
+        if (prefix !== '-ms-') return super.insert(decl, prefix, prefixes);
 
         const values = shorthand.parse(decl);
-
         const [start, span] = shorthand.translate(values, 0, 1);
 
         if (start) {

lib/hacks/grid-row-column.js

@@ -19,9 +19,6 @@ function convert(value) {
     return [false, false];
 }
 
-/**
- * Translate values to start-span
- */
 function translate(values, startIndex, endIndex) {
     const startValue = values[startIndex];
     const endValue = values[endIndex];
@@ -90,9 +87,6 @@ function parseTemplateShortcut(decl) {
     return values;
 }
 
-/**
- * Recursive part of changeRepeat
- */
 function walkRepeat(node) {
     const fixed = [];
     for (const i of node.nodes) {
@@ -113,25 +107,6 @@ function walkRepeat(node) {
     node.nodes = fixed;
 }
 
-
-/**
- * Check if prop is already present
- */
-function isAlreadyApplied(decl, prop) {
-    for (const i in decl.parent.nodes) {
-        if (decl.parent.nodes.hasOwnProperty(i)) {
-            const element = decl.parent.nodes[i];
-            if (element.prop === prop) {
-                return false;
-            }
-        }
-    }
-    return true;
-}
-
-/**
- * IE repeating syntax
- */
 function changeRepeat(value) {
     const ast = parser(value);
     walkRepeat(ast);
@@ -142,6 +117,5 @@ module.exports = {
     parse,
     translate,
     changeRepeat,
-    isAlreadyApplied,
     parseTemplateShortcut
 };