Fix: force, buildFromSource cli opts are ignored in yarn

[joaomoreno]

The issue comes from this changes 4 years ago which fixed the issue that sources were always compiling when used in yarn: e9065dd

This fix seems irrelevant by now, when one looks at the code paths. It also blocks the usage of the force and buildFromSource options. It seems safe to simply remove the check altogether. I have verified that doing so makes prebuild-install correctly download or build from source when explicitly told so, using yarn.

Co-authored-by: Benjamin Pasero benjpas@microsoft.com
Fixes: #139

[vweevers]

This fix seems irrelevant by now, when one looks at the code paths.

Can you elaborate? Is it b6f3b36 that made the fix irrelevant?

[joaomoreno]

Good question. And now that I look at it again, it just seems that e9065dd was simply a bad fix, since it just makes it that in yarn, it would always load from https, regardless of the buildFromSource opt value.

What would be interesting to find out was: what was making prebuild-install misbehave in the presence of yarn, such that that commit was necessary?

[vweevers]

What would be interesting to find out was: what was making prebuild-install misbehave in the presence of yarn, such that that commit was necessary?

prebuild-install/bin.js

Lines 45 to 49 in e9065dd

	if (util.isYarnPath(execPath) && /node_modules/.test(process.cwd())) {
	// From yarn repository
	} else if (!(typeof pkg._from === 'string')) {
	log.info('install', 'installing inside prebuild-install directory, skipping download.')
	process.exit(1)

The first if-branch was added because yarn would always match the second if-branch, because it didn't add metadata (like _from) to package.json files on disk, like npm did (until npm 7).

[vweevers]

It seems safe to simply remove the check altogether.

I agree, as prebuild-install has been updated to be compatible with npm 7 which (long story short) means that the absence of pkg._from is no longer an issue.

[vweevers]

6.1.1

[joaomoreno]

Thank you!