Skip to content

Commit 78212f5

Browse files
authored
Merge pull request #117 from primer/remove_font
Removing the webfont and everything that builds the webfont
2 parents 62c6727 + 66f1a80 commit 78212f5

18 files changed

Lines changed: 19 additions & 1507 deletions

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
### HEAD
22

3+
### 5.0.0
4+
5+
Removes:
6+
7+
- Deprecating support for the webfont
8+
9+
### 4.4.0
10+
311
Adds:
412

513
- svg.json file that is accessible from node require

Gruntfile.js

Lines changed: 2 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@ module.exports = function(grunt) {
3333
},
3434
dist: {
3535
files: {
36-
'build/octicons.min.css': 'build/octicons.css',
37-
'build/font/octicons.min.css': 'build/font/octicons.css'
36+
'build/octicons.min.css': 'build/octicons.css'
3837
}
3938
}
4039
},
@@ -81,45 +80,7 @@ module.exports = function(grunt) {
8180
}
8281
},
8382

84-
webfont: {
85-
options: {
86-
font: "octicons",
87-
fontFamilyName: "Octicons",
88-
types: 'eot,woff,woff2,ttf,svg',
89-
fontHeight: 96,
90-
normalize: false,
91-
ascent: 84,
92-
descent: 12,
93-
htmlDemo: false,
94-
codepointsFile: 'lib/font/codepoints.json',
95-
templateOptions: {
96-
baseClass: 'octicon',
97-
classPrefix: 'octicon-',
98-
mixinPrefix: 'octicon-',
99-
fontFamilyName: "Octicons"
100-
}
101-
},
102-
octicons_css: {
103-
src: 'lib/svg/*.svg',
104-
dest: 'build/font',
105-
options: {
106-
template: 'lib/font/template.css'
107-
}
108-
},
109-
octicons_scss: {
110-
src: 'lib/svg/*.svg',
111-
dest: 'build/font',
112-
options: {
113-
stylesheet: 'scss',
114-
template: 'lib/font/template.scss'
115-
}
116-
}
117-
},
118-
11983
clean: {
120-
font: [
121-
'build/font/*'
122-
],
12384
svg: [
12485
'build/svg/*',
12586
'build/sprite.octicons.svg',
@@ -131,18 +92,16 @@ module.exports = function(grunt) {
13192
grunt.loadNpmTasks('grunt-contrib-clean');
13293
grunt.loadNpmTasks('grunt-postcss');
13394
grunt.loadNpmTasks('grunt-svg-sprite');
134-
grunt.loadNpmTasks('grunt-webfont');
13595
grunt.loadNpmTasks('grunt-svgmin');
13696
grunt.loadNpmTasks('grunt-cssnano');
13797
grunt.loadNpmTasks('grunt-sass');
13898

13999
// build tasks
140100
grunt.registerTask('css', ['sass', 'postcss', 'cssnano']);
141-
grunt.registerTask('font', ['clean:font', 'webfont']);
142101
grunt.registerTask('svg', ['clean:svg', 'svgmin', 'svg_sprite']);
143102

144103
// default task, build /dist/
145-
grunt.registerTask('default', [ 'svg', 'font', 'css', 'svg_json']);
104+
grunt.registerTask('default', [ 'svg', 'css', 'svg_json']);
146105

147106
grunt.registerTask('svg_json', 'create a json object with all minimized svg', function() {
148107
var result = {}

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ You’ll next need to build your Octicons.
3838
All the files you need will be in the `/build/` directory already, but if you’ve made changes to the `/lib/` directory and need to regenerate, follow these steps:
3939

4040
1. Open the Octicons directory in Terminal
41-
2. Run the command `script/bootstrap`. This will install any necessary dependencies for generating the Octicons font and SVGs.
42-
3. Run the command `grunt`. Running the grunt task will generate the font and SVGs, placing them in the `/build/` directory.
41+
2. `npm install` to install all dependencies for the project.
42+
3. Run the command `npm run build`. This will run the grunt task to build the SVGs, placing them in the `/build/` directory.
4343

4444
## Publishing
4545

@@ -56,8 +56,8 @@ If you have access to publish this repository, these are the steps to publishing
5656

5757
When using the GitHub logos, be sure to follow the [GitHub logo guidelines](https://github.com/logos).
5858

59-
_Font License:_ [SIL OFL 1.1](http://scripts.sil.org/OFL)
60-
Applies to all font files and SVG files
59+
_SVG License:_ [SIL OFL 1.1](http://scripts.sil.org/OFL)
60+
Applies to all SVG files
6161

6262
_Code License:_ [MIT](./LICENSE)
6363
Applies to all other files

0 commit comments

Comments
 (0)