Register WP-CLI command on cli_init

Replace direct CLI setup call in the constructor with an action hook: the constructor now hooks a new cli_init() method to the 'cli_init' action instead of calling cli() directly. The private method was renamed from cli() to cli_init() and the explicit WP_CLI runtime check was removed (registration now occurs on cli_init, which only runs under WP-CLI). The WP_CLI::add_command() registration remains unchanged.

Author: remcotolsma

src/Subscriptions/SubscriptionsFollowUpPaymentsController.php

@@ -33,7 +33,7 @@ public function setup() {
 
 		\add_action( 'pronamic_pay_create_subscription_follow_up_payment', $this->action_create_subscription_follow_up_payment( ... ) );
 
-		$this->cli();
+		\add_action( 'cli_init', $this->cli_init( ... ) );
 	}
 
 	/**
@@ -44,11 +44,7 @@ public function setup() {
 	 * @link https://make.wordpress.org/cli/handbook/commands-cookbook/
 	 * @return void
 	 */
-	private function cli() {
-		if ( ! ( defined( 'WP_CLI' ) && WP_CLI ) ) {
-			return;
-		}
-
+	private function cli_init() {
 		WP_CLI::add_command(
 			'pay subscription list',
 			function (): void {