Add shared iDEAL payment method and reuse images (#251)

* Add shared iDEAL payment method and reuse images

Introduce a single $payment_method_ideal instance with name, description and image paths and register it earlier in Plugin::init. Reuse its images for the direct-debit-ideal payment method instead of duplicating the image array, and remove the later duplicate iDEAL block. This deduplicates code and ensures consistent iDEAL/Wero branding assets while keeping existing behavior.

* Consolidate iDEAL rebranding block

Move the iDEAL logo rebranding conditional to immediately after creating $payment_method_ideal so the name/images are set before adding the payment method, and remove the duplicated block later in the file. This ensures the iDEAL branding (effective 2026-01-29) is applied once and avoids redundant assignments.

Author: remcotolsma

src/Plugin.php

@@ -829,6 +829,36 @@ public function register_payment_methods(): void {
 
 		$this->payment_methods->add( $payment_method_credit_card );
 
+		// Payment method iDEAL | Wero.
+		$payment_method_ideal = new PaymentMethod( PaymentMethods::IDEAL );
+
+		$payment_method_ideal->descriptions = [
+			'customer' => \__( 'With iDEAL you can easily pay online in the secure environment of your own bank.', 'pronamic_ideal' ),
+		];
+
+		$payment_method_ideal->name = \__( 'iDEAL | Wero', 'pronamic_ideal' );
+
+		$payment_method_ideal->images = [
+			'640x360'     => $image_service->get_path( 'other/ideal-wero/ideal-wero-640x360.svg' ),
+			'woocommerce' => $image_service->get_path( 'other/ideal-wero/method-ideal-wero-wc-51x32.svg' ),
+		];
+
+		/**
+		 * The iDEAL logo rebranding takes effect on January 29, 2026.
+		 *
+		 * @link https://ideal.nl/en/ideal-wero-branding
+		 */
+		if ( \time() < \strtotime( '2026-01-29 00:00:00' ) ) {
+			$payment_method_ideal->name = \__( 'iDEAL', 'pronamic_ideal' );
+
+			$payment_method_ideal->images = [
+				'640x360'     => $image_service->get_path( 'methods/ideal/method-ideal-640x360.svg' ),
+				'woocommerce' => $image_service->get_path( 'methods/ideal/method-ideal-wc-51x32.svg' ),
+			];
+		}
+
+		$this->payment_methods->add( $payment_method_ideal );
+
 		// Direct debit.
 		$payment_method_direct_debit = new PaymentMethod( PaymentMethods::DIRECT_DEBIT );
 
@@ -861,9 +891,7 @@ public function register_payment_methods(): void {
 			'customer' => \sprintf( $description_template, $payment_method_direct_debit_ideal->name ),
 		];
 
-		$payment_method_direct_debit_ideal->images = [
-			'woocommerce' => $image_service->get_path( 'methods/direct-debit-ideal/method-direct-debit-ideal-wc-107x32.svg' ),
-		];
+		$payment_method_direct_debit_ideal->images = $payment_method_ideal->images;
 
 		$this->payment_methods->add( $payment_method_direct_debit_ideal );
 
@@ -903,36 +931,6 @@ public function register_payment_methods(): void {
 
 		$this->payment_methods->add( $payment_method_gift_card );
 
-		// IDEAL.
-		$payment_method_ideal = new PaymentMethod( PaymentMethods::IDEAL );
-
-		$payment_method_ideal->descriptions = [
-			'customer' => \__( 'With iDEAL you can easily pay online in the secure environment of your own bank.', 'pronamic_ideal' ),
-		];
-
-		$payment_method_ideal->name = \__( 'iDEAL | Wero', 'pronamic_ideal' );
-
-		$payment_method_ideal->images = [
-			'640x360'     => $image_service->get_path( 'other/ideal-wero/ideal-wero-640x360.svg' ),
-			'woocommerce' => $image_service->get_path( 'other/ideal-wero/method-ideal-wero-wc-51x32.svg' ),
-		];
-
-		/**
-		 * The iDEAL logo rebranding takes effect on January 29, 2026.
-		 *
-		 * @link https://ideal.nl/en/ideal-wero-branding
-		 */
-		if ( \time() < \strtotime( '2026-01-29 00:00:00' ) ) {
-			$payment_method_ideal->name = \__( 'iDEAL', 'pronamic_ideal' );
-
-			$payment_method_ideal->images = [
-				'640x360'     => $image_service->get_path( 'methods/ideal/method-ideal-640x360.svg' ),
-				'woocommerce' => $image_service->get_path( 'methods/ideal/method-ideal-wc-51x32.svg' ),
-			];
-		}
-
-		$this->payment_methods->add( $payment_method_ideal );
-
 		// IDEAL QR.
 		$payment_method_ideal_qr = new PaymentMethod( PaymentMethods::IDEALQR );