Skip to content

Commit 31da56c

Browse files
committed
Other: Various jsdoc improvements and a workaround for d.ts generation, see #592
1 parent 39a2ea3 commit 31da56c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+5183
-321
lines changed

cli/targets/json-module.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
11
"use strict";
22
module.exports = json_module;
33

4-
var path = require("path"),
5-
fs = require("fs"),
6-
util = require("../util");
7-
8-
var protobuf = require("../..");
4+
var util = require("../util");
95

106
json_module.description = "JSON representation as a module"
117

@@ -17,6 +13,7 @@ function json_module(root, options, callback) {
1713
callback(null, output);
1814
});
1915
} catch (e) {
20-
callback(e);
16+
return callback(e);
2117
}
18+
return undefined;
2219
}

cli/targets/static.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ function buildType(ref, type) {
238238
var prop = util.safeProp(field.name);
239239
pushComment([
240240
type.name + " " + field.name + ".",
241-
prop.charAt(0) !== "." ? "@name " + fullName + "#" + name(field.name) : null,
241+
prop.charAt(0) !== "." ? "@name " + fullName + "#" + field.name : null,
242242
"@type {" + jsType + "}"
243243
]);
244244
if (Array.isArray(field.defaultValue)) {

0 commit comments

Comments
 (0)