Skip to content

Commit 3f6ffd0

Browse files
committed
Other: Restrict comment parsing for static code to explicit /**-blocks because old protos may generate a lot of nonsense otherwise, see #640
1 parent 340d6aa commit 3f6ffd0

22 files changed

+186
-540
lines changed

cli/targets/static.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -652,7 +652,7 @@ function buildEnum(ref, enm) {
652652
);
653653
Object.keys(enm.values).forEach(function(key) {
654654
var val = enm.values[key];
655-
comment.push("@property {number} " + key + "=" + val + " " + (enm.comments[key] ? enm.comments[key] : key + " value"));
655+
comment.push("@property {number} " + key + "=" + val + " " + (enm.comments[key] || key + " value"));
656656
});
657657
pushComment(comment);
658658
push(name(ref) + "." + name(enm.name) + " = (function() {");

dist/noparse/protobuf.js

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/noparse/protobuf.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/noparse/protobuf.min.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/noparse/protobuf.min.js.gz

14 Bytes
Binary file not shown.

dist/noparse/protobuf.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/protobuf.js

Lines changed: 29 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/protobuf.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/protobuf.min.js

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/protobuf.min.js.gz

-14 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)