Skip to content

Commit 5606cb1

Browse files
committed
Refactoring; Removed the need for triple-slash references in .d.ts by providing a minimal Long interface, see #527, see #530
1 parent 228a202 commit 5606cb1

File tree

12 files changed

+54
-31
lines changed

12 files changed

+54
-31
lines changed

.zuul.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ browsers:
1717
- name: iphone
1818
version: [8.1, 9.0, latest]
1919
scripts:
20-
- scripts/polyfill.js
20+
- lib/polyfill.js
2121
- node_modules/long/dist/long.js
2222
tunnel:
2323
type: ngrok

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ message HelloReply {
185185
```js
186186
...
187187
var Greeter = root.lookup("Greeter");
188-
var greeter = Greeter.create(rpcImpl);
188+
var greeter = Greeter.create(rpcImpl, false, false); // rpcImpl (see below), requestDelimited?, responseDelimited?
189189

190190
greeter.sayHello({ name: 'you' }, function(err, response) {
191191
console.log('Greeting:', response.message);

dist/protobuf.js

Lines changed: 15 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/protobuf.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/protobuf.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/protobuf.min.js.gz

-1 Bytes
Binary file not shown.

dist/protobuf.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
File renamed without changes.

runtime.js

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,6 @@
1-
"use strict";
2-
3-
/**
4-
* Minimal static codegen runtime.
5-
* @namespace
6-
*/
7-
var runtime = exports;
8-
9-
/** @alias Reader */
10-
runtime.Reader = require("./src/reader");
11-
12-
/** @alias Writer */
13-
runtime.Writer = require("./src/writer");
14-
15-
/** @alias util */
16-
runtime.util = require("./src/util/runtime");
1+
// This file exports just the bare minimum required to work with statically generated code.
2+
// Can be used as a drop-in replacement for the full library as it has the same general structure.
3+
var protobuf_rt = exports;
4+
protobuf_rt.Reader = require("./src/reader");
5+
protobuf_rt.Writer = require("./src/writer");
6+
protobuf_rt.util = require("./src/util/runtime");

scripts/types.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,8 @@ var fs = require("fs"),
44
var dir = path.join(__dirname, "..", "types");
55

66
var header = [
7-
'/// <reference types="node" />',
8-
'/// <reference types="long" />',
9-
"",
7+
// '/// <reference types="long" />',
8+
// "",
109
"/*",
1110
" * protobuf.js v" + pkg.version + " TypeScript definitions",
1211
" * Generated " + (new Date()).toUTCString().replace(/GMT/, "UTC"),

0 commit comments

Comments
 (0)