Skip to content

Commit 6229799

Browse files
committed
Fixed: Prevent parse errors when generating service method names, see #870
1 parent 478f332 commit 6229799

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/service.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,8 @@ Service.prototype.remove = function remove(object) {
152152
Service.prototype.create = function create(rpcImpl, requestDelimited, responseDelimited) {
153153
var rpcService = new rpc.Service(rpcImpl, requestDelimited, responseDelimited);
154154
for (var i = 0, method; i < /* initializes */ this.methodsArray.length; ++i) {
155-
rpcService[util.lcFirst((method = this._methodsArray[i]).resolve().name)] = util.codegen(["r","c"], util.lcFirst(method.name))("return this.rpcCall(m,q,s,r,c)")({
155+
var methodName = util.lcFirst((method = this._methodsArray[i]).resolve().name).replace(/[^$\w_]/g, "");
156+
rpcService[methodName] = util.codegen(["r","c"], util.isReserved(methodName) ? methodName + "_" : methodName)("return this.rpcCall(m,q,s,r,c)")({
156157
m: method,
157158
q: method.resolvedRequestType.ctor,
158159
s: method.resolvedResponseType.ctor

0 commit comments

Comments
 (0)