Skip to content

Commit 964f65a

Browse files
committed
Refactored BufferReader/Writer to their own files and removed unnecessary operations (node always has FloatXXArray and browser buffer uses ieee anyway)
1 parent 7939a4b commit 964f65a

19 files changed

+471
-533
lines changed

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -487,8 +487,7 @@ Note that JSON is a native binding nowadays and as such is about as fast as it p
487487
* Reader and writer interfaces configure themselves according to the environment to eliminate redundant conditionals.
488488
* Node-specific reader and writer subclasses benefit from node's buffer binding.
489489
* Reflection has built-in code generation that builds type-specific encoders, decoders and verifiers at runtime.
490-
* Encoders and decoders do not verify that required fields are present (with proto3 this is dead code anyway). There is a `verify` method to check this manually instead - where applicable.
491-
* For entirely bogus values encoders intentionally rely on runtime errors to be thrown somewhere down the road.
490+
* Encoders and decoders do not implicitly call `verify` on messages to avoid unnecessary overhead where messages are already known to be valid. It's up to the user to call `verify` where necessary.
492491
* Quite a bit of V8-specific profiling is accountable for everything else.
493492

494493
You can also run [the benchmark](https://github.com/dcodeIO/protobuf.js/blob/master/bench/index.js) ...

0 commit comments

Comments
 (0)