remove return type requirement of pbjs callback#1025
Merged
dcodeIO merged 3 commits intoprotobufjs:masterfrom May 18, 2018
Merged
remove return type requirement of pbjs callback#1025dcodeIO merged 3 commits intoprotobufjs:masterfrom
dcodeIO merged 3 commits intoprotobufjs:masterfrom
Conversation
The callback function of pbjs main should not enforce a return value.
Member
|
Iirc, it may return an exit code, see. Not sure why it stated |
Contributor
Author
|
I re-read the code again, the return type is the function of pbjs.main, but not the callback function. Will revert the commit. |
Member
|
Thanks! |
dcodeIO
pushed a commit
that referenced
this pull request
May 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The callback function of pbjs main should not enforce a return value.