feat: better comment parse#1419
Merged
alexander-fenster merged 5 commits intoprotobufjs:masterfrom Jun 26, 2020
Merged
Conversation
Contributor
recih
commented
Jun 9, 2020
- fix trailing comment in last line can be recognized as leading comment for current field by mistake.
- new preferTrailingComment option in IParseOptions, user can choose the priority of trailing comments and leading commnets
- test updated.
Contributor
|
Can you explain a bit more what the incorrect previous behavior was and how your fix changes it? |
Contributor
Author
when there is no extra new line between two fields, you will get after my fix, you will get: also there is an option |
Contributor
Author
|
@murgatroid99 will you review my PR, please ❤️ |
murgatroid99
approved these changes
Jun 26, 2020
alexander-fenster
approved these changes
Jun 26, 2020
taylorcode
pushed a commit
to taylorcode/protobuf.js
that referenced
this pull request
Oct 16, 2020
* fix trailing comment in last line recognized as leading comment for current token. * add preferTrailingComment to IParseOptions Co-authored-by: Alexander Fenster <fenster@google.com>
This was referenced May 20, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.