Skip to content

fix: allow for an optional semicolon where there is an optional comma in parseOptionValue#1571

Merged
alexander-fenster merged 4 commits intoprotobufjs:masterfrom
jeffory-orrok:issue_1569
Apr 29, 2021
Merged

fix: allow for an optional semicolon where there is an optional comma in parseOptionValue#1571
alexander-fenster merged 4 commits intoprotobufjs:masterfrom
jeffory-orrok:issue_1569

Conversation

@jeffory-orrok
Copy link
Copy Markdown
Contributor

@jeffory-orrok jeffory-orrok commented Mar 25, 2021

Fixes #1569.

This is to conform with behavior found in text_format.cc

    // For historical reasons, fields may optionally be separated by commas or
    // semicolons.
    TryConsume(";") || TryConsume(",");

@alexander-fenster alexander-fenster changed the title allow for an optional semicolon where there is an optional comma in parseOptionValue fix: allow for an optional semicolon where there is an optional comma in parseOptionValue Apr 29, 2021
@alexander-fenster
Copy link
Copy Markdown
Contributor

@alexander-fenster alexander-fenster merged commit af1b449 into protobufjs:master Apr 29, 2021
@jeffory-orrok
Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Illegal name ';' when parsing the rhs of an option assignment that is not a simple strLit

2 participants