fix: possible infinite loop when parsing option#1923
Merged
alexander-fenster merged 1 commit intomasterfrom Aug 21, 2023
Merged
fix: possible infinite loop when parsing option#1923alexander-fenster merged 1 commit intomasterfrom
alexander-fenster merged 1 commit intomasterfrom
Conversation
05626e3 to
85560dd
Compare
bcoe
approved these changes
Aug 21, 2023
Merged
This was referenced Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
whileloop inparseOptionValuecan be infinite if the closing brace}it expects never comes.Reported by @oetr.
Minor unrelated changes also in this PR, because I'm too lazy to create a separate one:
eslint-disable-lineto a propereslint-disable-next-linein a few places to fix linting errors;