Skip to content

Fix toDescriptor for proto3 optional extensions#2122

Merged
alexander-fenster merged 1 commit intoprotobufjs:masterfrom
serkanerip:master
Mar 11, 2026
Merged

Fix toDescriptor for proto3 optional extensions#2122
alexander-fenster merged 1 commit intoprotobufjs:masterfrom
serkanerip:master

Conversation

@serkanerip
Copy link
Copy Markdown
Contributor

  • Skip oneof index lookup when the field’s parent is not a Type
  • Add regression test for proto3 optional fields in extend blocks

Fixes #1958

@alexander-fenster alexander-fenster merged commit 1cac5cf into protobufjs:master Mar 11, 2026
@github-actions github-actions bot mentioned this pull request Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'indexOf')

2 participants