fix: do not allow setting __proto__ in Message constructor#2126
Merged
alexander-fenster merged 1 commit intomasterfrom Mar 11, 2026
Merged
fix: do not allow setting __proto__ in Message constructor#2126alexander-fenster merged 1 commit intomasterfrom
alexander-fenster merged 1 commit intomasterfrom
Conversation
When a properties object passed to Message constructor contains
__proto__, such as in
const properties = JSON.parse('{"__proto__": {"polluted": "yes"}}');
const message = new protobuf.Message(properties);
the resulting message object will have message.polluted defined
which is not intended.
Filter out __proto__ when iterating over the keys of the properties.
sofisl
approved these changes
Mar 11, 2026
Merged
vasiliiperfilev
pushed a commit
to vasiliiperfilev/protobuf.js
that referenced
this pull request
Apr 14, 2026
…s#2126) When a properties object passed to Message constructor contains __proto__, such as in const properties = JSON.parse('{"__proto__": {"polluted": "yes"}}'); const message = new protobuf.Message(properties); the resulting message object will have message.polluted defined which is not intended. Filter out __proto__ when iterating over the keys of the properties.
alexander-fenster
added a commit
that referenced
this pull request
Apr 15, 2026
When a properties object passed to Message constructor contains
__proto__, such as in
const properties = JSON.parse('{"__proto__": {"polluted": "yes"}}');
const message = new protobuf.Message(properties);
the resulting message object will have message.polluted defined
which is not intended.
Filter out __proto__ when iterating over the keys of the properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2125.
When a properties object passed to
Messageconstructor contains__proto__, such as inthe resulting message object will have
message.polluteddefined which is not intended.Filter out
__proto__when iterating over the keys of the properties.