Skip to content

Commit 158bf35

Browse files
authored
refactor: remove mutable and reflect properties from _hideMsg in form… (#8541)
1 parent 00fc0e3 commit 158bf35

File tree

28 files changed

+70
-70
lines changed

28 files changed

+70
-70
lines changed

packages/components/src/components/combobox/shadow.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ export class KolCombobox implements ComboboxAPI {
396396
* Hides the error message but leaves it in the DOM for the input's aria-describedby.
397397
* @TODO: Change type back to `HideMsgPropType` after Stencil#4663 has been resolved.
398398
*/
399-
@Prop({ mutable: true, reflect: true }) public _hideMsg?: boolean = false;
399+
@Prop() public _hideMsg?: boolean = false;
400400

401401
/**
402402
* Hides the caption by default and displays the caption text with a tooltip when the

packages/components/src/components/combobox/test/__snapshots__/snapshot.spec.tsx.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ exports[`kol-combobox should render with _label="Label" _name="field" _placehold
215215
`;
216216
217217
exports[`kol-combobox should render with _label="Label" _name="field" _placeholder="Hier steht ein Platzhaltertext" _value="Herr" _suggestions=["Frau","Herr","Divers"] _msg={"_type":"error","_description":"Es ist ein Fehler aufgetreten"} _hideMsg=true _touched=true 1`] = `
218-
<kol-combobox _hide-msg="" _touched="" _value="Herr">
218+
<kol-combobox _touched="" _value="Herr">
219219
<template shadowrootmode="open" shadowrootdelegatesfocus>
220220
<div class="has-value kol-combobox kol-form-field kol-form-field--error kol-form-field--hidden-msg kol-form-field--msg-type-error kol-form-field--touched">
221221
<label class="kol-form-field__label" htmlfor="id-nonce" id="id-nonce-label">

packages/components/src/components/input-checkbox/shadow.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ export class KolInputCheckbox implements InputCheckboxAPI, FocusableElement {
167167
* Hides the error message but leaves it in the DOM for the input's aria-describedby.
168168
* @TODO: Change type back to `HideMsgPropType` after Stencil#4663 has been resolved.
169169
*/
170-
@Prop({ mutable: true, reflect: true }) public _hideMsg?: boolean = false;
170+
@Prop() public _hideMsg?: boolean = false;
171171

172172
/**
173173
* Makes the element not focusable and ignore all events.

packages/components/src/components/input-checkbox/test/__snapshots__/snapshot.spec.tsx.snap

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ exports[`kol-input-checkbox should render with _label="Label" _name="field" _pla
187187
`;
188188

189189
exports[`kol-input-checkbox should render with _label="Label" _name="field" _placeholder="Hier steht ein Platzhaltertext" _checked=false _labelAlign="left" _msg={"_type":"error","_description":"Es ist ein Fehler aufgetreten"} _hideMsg=true _touched=true 1`] = `
190-
<kol-input-checkbox _hide-msg="" _placeholder="Hier steht ein Platzhaltertext" _touched="">
190+
<kol-input-checkbox _placeholder="Hier steht ein Platzhaltertext" _touched="">
191191
<template shadowrootmode="open" shadowrootdelegatesfocus>
192192
<div class="kol-form-field kol-form-field--error kol-form-field--hidden-msg kol-form-field--msg-type-error kol-form-field--touched kol-input-checkbox kol-input-checkbox--label-align-left kol-input-checkbox--variant-default">
193193
<div class="kol-form-field__input">
@@ -530,7 +530,7 @@ exports[`kol-input-checkbox should render with _label="Label" _name="field" _pla
530530
`;
531531

532532
exports[`kol-input-checkbox should render with _label="Label" _name="field" _placeholder="Hier steht ein Platzhaltertext" _checked=false _variant="button" _msg={"_type":"error","_description":"Es ist ein Fehler aufgetreten"} _hideMsg=true _touched=true 1`] = `
533-
<kol-input-checkbox _hide-msg="" _placeholder="Hier steht ein Platzhaltertext" _touched="">
533+
<kol-input-checkbox _placeholder="Hier steht ein Platzhaltertext" _touched="">
534534
<template shadowrootmode="open" shadowrootdelegatesfocus>
535535
<div class="kol-form-field kol-form-field--error kol-form-field--hidden-msg kol-form-field--msg-type-error kol-form-field--touched kol-input-checkbox kol-input-checkbox--label-align-right kol-input-checkbox--variant-button" data-role="button">
536536
<div class="kol-form-field__input">
@@ -873,7 +873,7 @@ exports[`kol-input-checkbox should render with _label="Label" _name="field" _pla
873873
`;
874874

875875
exports[`kol-input-checkbox should render with _label="Label" _name="field" _placeholder="Hier steht ein Platzhaltertext" _checked=false _variant="switch" _msg={"_type":"error","_description":"Es ist ein Fehler aufgetreten"} _hideMsg=true _touched=true 1`] = `
876-
<kol-input-checkbox _hide-msg="" _placeholder="Hier steht ein Platzhaltertext" _touched="">
876+
<kol-input-checkbox _placeholder="Hier steht ein Platzhaltertext" _touched="">
877877
<template shadowrootmode="open" shadowrootdelegatesfocus>
878878
<div class="kol-form-field kol-form-field--error kol-form-field--hidden-msg kol-form-field--msg-type-error kol-form-field--touched kol-input-checkbox kol-input-checkbox--label-align-right kol-input-checkbox--variant-switch">
879879
<div class="kol-form-field__input">
@@ -1216,7 +1216,7 @@ exports[`kol-input-checkbox should render with _label="Label" _name="field" _pla
12161216
`;
12171217

12181218
exports[`kol-input-checkbox should render with _label="Label" _name="field" _placeholder="Hier steht ein Platzhaltertext" _checked=true _labelAlign="left" _msg={"_type":"error","_description":"Es ist ein Fehler aufgetreten"} _hideMsg=true _touched=true 1`] = `
1219-
<kol-input-checkbox _checked="" _hide-msg="" _placeholder="Hier steht ein Platzhaltertext" _touched="">
1219+
<kol-input-checkbox _checked="" _placeholder="Hier steht ein Platzhaltertext" _touched="">
12201220
<template shadowrootmode="open" shadowrootdelegatesfocus>
12211221
<div class="kol-form-field kol-form-field--error kol-form-field--hidden-msg kol-form-field--msg-type-error kol-form-field--touched kol-input-checkbox kol-input-checkbox--checked kol-input-checkbox--label-align-left kol-input-checkbox--variant-default">
12221222
<div class="kol-form-field__input">
@@ -1559,7 +1559,7 @@ exports[`kol-input-checkbox should render with _label="Label" _name="field" _pla
15591559
`;
15601560

15611561
exports[`kol-input-checkbox should render with _label="Label" _name="field" _placeholder="Hier steht ein Platzhaltertext" _checked=true _labelAlign="right" _msg={"_type":"error","_description":"Es ist ein Fehler aufgetreten"} _hideMsg=true _touched=true 1`] = `
1562-
<kol-input-checkbox _checked="" _hide-msg="" _placeholder="Hier steht ein Platzhaltertext" _touched="">
1562+
<kol-input-checkbox _checked="" _placeholder="Hier steht ein Platzhaltertext" _touched="">
15631563
<template shadowrootmode="open" shadowrootdelegatesfocus>
15641564
<div class="kol-form-field kol-form-field--error kol-form-field--hidden-msg kol-form-field--msg-type-error kol-form-field--touched kol-input-checkbox kol-input-checkbox--checked kol-input-checkbox--label-align-right kol-input-checkbox--variant-default">
15651565
<div class="kol-form-field__input">
@@ -1902,7 +1902,7 @@ exports[`kol-input-checkbox should render with _label="Label" _name="field" _pla
19021902
`;
19031903

19041904
exports[`kol-input-checkbox should render with _label="Label" _name="field" _placeholder="Hier steht ein Platzhaltertext" _checked=true _variant="button" _msg={"_type":"error","_description":"Es ist ein Fehler aufgetreten"} _hideMsg=true _touched=true 1`] = `
1905-
<kol-input-checkbox _checked="" _hide-msg="" _placeholder="Hier steht ein Platzhaltertext" _touched="">
1905+
<kol-input-checkbox _checked="" _placeholder="Hier steht ein Platzhaltertext" _touched="">
19061906
<template shadowrootmode="open" shadowrootdelegatesfocus>
19071907
<div class="kol-form-field kol-form-field--error kol-form-field--hidden-msg kol-form-field--msg-type-error kol-form-field--touched kol-input-checkbox kol-input-checkbox--checked kol-input-checkbox--label-align-right kol-input-checkbox--variant-button" data-role="button">
19081908
<div class="kol-form-field__input">
@@ -2245,7 +2245,7 @@ exports[`kol-input-checkbox should render with _label="Label" _name="field" _pla
22452245
`;
22462246

22472247
exports[`kol-input-checkbox should render with _label="Label" _name="field" _placeholder="Hier steht ein Platzhaltertext" _checked=true _variant="switch" _msg={"_type":"error","_description":"Es ist ein Fehler aufgetreten"} _hideMsg=true _touched=true 1`] = `
2248-
<kol-input-checkbox _checked="" _hide-msg="" _placeholder="Hier steht ein Platzhaltertext" _touched="">
2248+
<kol-input-checkbox _checked="" _placeholder="Hier steht ein Platzhaltertext" _touched="">
22492249
<template shadowrootmode="open" shadowrootdelegatesfocus>
22502250
<div class="kol-form-field kol-form-field--error kol-form-field--hidden-msg kol-form-field--msg-type-error kol-form-field--touched kol-input-checkbox kol-input-checkbox--checked kol-input-checkbox--label-align-right kol-input-checkbox--variant-switch">
22512251
<div class="kol-form-field__input">
@@ -2588,7 +2588,7 @@ exports[`kol-input-checkbox should render with _label="Label" _name="field" _pla
25882588
`;
25892589

25902590
exports[`kol-input-checkbox should render with _label="Label" _name="field" _placeholder="Hier steht ein Platzhaltertext" _indeterminate=true _msg={"_type":"error","_description":"Es ist ein Fehler aufgetreten"} _hideMsg=true _touched=true 1`] = `
2591-
<kol-input-checkbox _hide-msg="" _indeterminate="" _placeholder="Hier steht ein Platzhaltertext" _touched="">
2591+
<kol-input-checkbox _indeterminate="" _placeholder="Hier steht ein Platzhaltertext" _touched="">
25922592
<template shadowrootmode="open" shadowrootdelegatesfocus>
25932593
<div class="kol-form-field kol-form-field--error kol-form-field--hidden-msg kol-form-field--msg-type-error kol-form-field--touched kol-input-checkbox kol-input-checkbox--indeterminate kol-input-checkbox--label-align-right kol-input-checkbox--variant-default">
25942594
<div class="kol-form-field__input">

packages/components/src/components/input-color/shadow.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ export class KolInputColor implements InputColorAPI, FocusableElement {
186186
* Hides the error message but leaves it in the DOM for the input's aria-describedby.
187187
* @TODO: Change type back to `HideMsgPropType` after Stencil#4663 has been resolved.
188188
*/
189-
@Prop({ mutable: true, reflect: true }) public _hideMsg?: boolean = false;
189+
@Prop() public _hideMsg?: boolean = false;
190190

191191
/**
192192
* Hides the caption by default and displays the caption text with a tooltip when the
@@ -266,7 +266,7 @@ export class KolInputColor implements InputColorAPI, FocusableElement {
266266
/**
267267
* Defines the value of the input.
268268
*/
269-
@Prop({ reflect: true }) public _value?: string;
269+
@Prop() public _value?: string;
270270

271271
@State() public state: InputColorStates = {
272272
_hideMsg: false,

0 commit comments

Comments
 (0)