File tree Expand file tree Collapse file tree 3 files changed +17
-8
lines changed
Expand file tree Collapse file tree 3 files changed +17
-8
lines changed Original file line number Diff line number Diff line change 11name : Benchmark-Monitoring
22
33on :
4- push :
5- branches :
6- - develop
4+ workflow_dispatch :
75
86concurrency :
97 group : ' workflow-${{ github.workflow }}-${{ github.ref }}'
Original file line number Diff line number Diff line change 11name : Benchmark-PR-Check
22
33on :
4- pull_request :
4+ workflow_dispatch :
5+ inputs :
6+ pr-number :
7+ description : Pull request number to comment on
8+ required : true
59
610concurrency :
711 group : ' workflow-${{ github.workflow }}-${{ github.ref }}'
812 cancel-in-progress : true
913
1014jobs :
1115 benchmark :
12- # Skip this job when the base clone URL may be different from the head clone URL.
13- if : github.event.pull_request.head.repo.fork == false
1416 runs-on : ubuntu-latest
1517 steps :
1618 - uses : actions/checkout@v4
@@ -31,12 +33,12 @@ jobs:
3133 with :
3234 body-includes : Hydration Benchmark Report
3335 comment-author : ' github-actions[bot]'
34- issue-number : ${{ github.event.pull_request. number }}
36+ issue-number : ${{ github.event.inputs.pr- number }}
3537
3638 - name : Post PR Comment
3739 uses : peter-evans/create-or-update-comment@v4
3840 with :
3941 body-path : packages/tools/benchmark-tests/benchmark-report.md
4042 comment-id : ${{ steps.fc.outputs.comment-id }}
4143 edit-mode : replace
42- issue-number : ${{ github.event.pull_request. number }}
44+ issue-number : ${{ github.event.inputs.pr- number }}
Original file line number Diff line number Diff line change @@ -47,3 +47,12 @@ updating texts when the component is rerendered. Cache the value in a class
4747property whose name starts with ` translate ` followed by the translation
4848identifier, for example ` translateSort ` for ` kol-sort ` or ` translateOrderBy `
4949for ` kol-order-by ` .
50+
51+ ### Properties
52+
53+ To make the components easier to learn, property names and their descriptions should be consistent across components. Therefore you should:
54+
55+ - Use the same property name for attributes that serve the same purpose.
56+ - Whenever possible, use identical descriptions for identical property names.
57+ - Whenever possible, keep the types of identical property names the same.
58+ - Minimize the number of different properties, descriptions and types.
You can’t perform that action at this time.
0 commit comments