Skip to content

Commit 7e88bd1

Browse files
authored
fix(pagination): remove exportparts from page buttons (#8028)
2 parents 9aece38 + 1286266 commit 7e88bd1

File tree

2 files changed

+15
-28
lines changed

2 files changed

+15
-28
lines changed

packages/components/src/components/pagination/shadow.tsx

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -305,34 +305,35 @@ export class KolPagination implements PaginationAPI {
305305
};
306306

307307
private getUnselectedPageButton(page: number): JSX.Element {
308+
const pageText = NUMBER_FORMATTER.format(page);
308309
return (
309310
<li key={nonce()}>
310311
<KolButtonWcTag
311-
exportparts="icon"
312+
_ariaDescription={`${translate('kol-page')} ${pageText}`}
312313
_customClass={this.state._customClass}
313-
_label=""
314+
_label={pageText}
314315
_on={{
315316
onClick: (event: Event) => {
316317
this.onClick(event, page);
317318
},
318319
}}
319-
>
320-
<span slot="expert">
321-
<span class="visually-hidden">{translate('kol-page')}</span> {NUMBER_FORMATTER.format(page)}
322-
</span>
323-
</KolButtonWcTag>
320+
></KolButtonWcTag>
324321
</li>
325322
);
326323
}
327324

328325
private getSelectedPageButton(page: number): JSX.Element {
326+
const pageText = NUMBER_FORMATTER.format(page);
329327
return (
330328
<li key={nonce()}>
331-
<KolButtonWcTag class="selected" _customClass={this.state._customClass} _disabled={true} _label="">
332-
<span slot="expert">
333-
<span class="visually-hidden">{translate('kol-page')}</span> {NUMBER_FORMATTER.format(page)}
334-
</span>
335-
</KolButtonWcTag>
329+
<KolButtonWcTag
330+
aria-current="page"
331+
class="selected"
332+
_ariaDescription={`${translate('kol-page')} ${pageText}`}
333+
_customClass={this.state._customClass}
334+
_disabled={true}
335+
_label={pageText}
336+
></KolButtonWcTag>
336337
</li>
337338
);
338339
}

packages/components/src/components/pagination/test/__snapshots__/snapshot.spec.tsx.snap

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -22,24 +22,10 @@ exports[`kol-pagination should render with _label="Label" _on={} _max=2 _page=1
2222
<kol-button-wc _disabled="" _hidelabel="" _label="kol-page-back" _tooltipalign="top" class="previous" exportparts="icon"></kol-button-wc>
2323
</li>
2424
<li>
25-
<kol-button-wc _disabled="" _label="" class="selected">
26-
<span slot="expert">
27-
<span class="visually-hidden">
28-
kol-page
29-
</span>
30-
1
31-
</span>
32-
</kol-button-wc>
25+
<kol-button-wc _ariadescription="kol-page 1" _disabled="" _label="1" aria-current="page" class="selected"></kol-button-wc>
3326
</li>
3427
<li>
35-
<kol-button-wc _label="" exportparts="icon">
36-
<span slot="expert">
37-
<span class="visually-hidden">
38-
kol-page
39-
</span>
40-
2
41-
</span>
42-
</kol-button-wc>
28+
<kol-button-wc _ariadescription="kol-page 2" _label="2"></kol-button-wc>
4329
</li>
4430
<li>
4531
<kol-button-wc _hidelabel="" _label="kol-page-next" _tooltipalign="top" class="next" exportparts="icon"></kol-button-wc>

0 commit comments

Comments
 (0)