Skip to content

Commit a2d8b9c

Browse files
committed
fix(pagination): remove exportparts from all buttons
1 parent d87f373 commit a2d8b9c

File tree

2 files changed

+17
-36
lines changed

2 files changed

+17
-36
lines changed

packages/components/src/components/pagination/shadow.tsx

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ export class KolPagination implements PaginationAPI {
105105
<li>
106106
<KolButtonWcTag
107107
class="first"
108-
exportparts="icon"
109108
_customClass={this.state._customClass}
110109
_disabled={this.state._page <= 1}
111110
_icons={leftDoubleArrowIcon}
@@ -120,7 +119,6 @@ export class KolPagination implements PaginationAPI {
120119
<li>
121120
<KolButtonWcTag
122121
class="previous"
123-
exportparts="icon"
124122
_customClass={this.state._customClass}
125123
_disabled={this.state._page <= 1}
126124
_icons={leftSingleArrow}
@@ -136,7 +134,6 @@ export class KolPagination implements PaginationAPI {
136134
<li>
137135
<KolButtonWcTag
138136
class="next"
139-
exportparts="icon"
140137
_customClass={this.state._customClass}
141138
_disabled={count <= this.state._page}
142139
_icons={rightSingleArrowIcon}
@@ -151,7 +148,6 @@ export class KolPagination implements PaginationAPI {
151148
<li>
152149
<KolButtonWcTag
153150
class="last"
154-
exportparts="icon"
155151
_customClass={this.state._customClass}
156152
_disabled={count <= this.state._page}
157153
_icons={rightDoubleArrowIcon}
@@ -308,31 +304,30 @@ export class KolPagination implements PaginationAPI {
308304
return (
309305
<li key={nonce()}>
310306
<KolButtonWcTag
311-
exportparts="icon"
307+
_ariaDescription={translate('kol-page')}
312308
_customClass={this.state._customClass}
313-
_label=""
309+
_label={NUMBER_FORMATTER.format(page)}
314310
_on={{
315311
onClick: (event: Event) => {
316312
this.onClick(event, page);
317313
},
318314
}}
319-
>
320-
<span slot="expert">
321-
<span class="visually-hidden">{translate('kol-page')}</span> {NUMBER_FORMATTER.format(page)}
322-
</span>
323-
</KolButtonWcTag>
315+
></KolButtonWcTag>
324316
</li>
325317
);
326318
}
327319

328320
private getSelectedPageButton(page: number): JSX.Element {
329321
return (
330322
<li key={nonce()}>
331-
<KolButtonWcTag class="selected" _customClass={this.state._customClass} _disabled={true} _label="">
332-
<span slot="expert">
333-
<span class="visually-hidden">{translate('kol-page')}</span> {NUMBER_FORMATTER.format(page)}
334-
</span>
335-
</KolButtonWcTag>
323+
<KolButtonWcTag
324+
class="selected"
325+
aria-current="page"
326+
_ariaDescription={translate('kol-page')}
327+
_customClass={this.state._customClass}
328+
_disabled={true}
329+
_label={NUMBER_FORMATTER.format(page)}
330+
></KolButtonWcTag>
336331
</li>
337332
);
338333
}

packages/components/src/components/pagination/test/__snapshots__/snapshot.spec.tsx.snap

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -16,36 +16,22 @@ exports[`kol-pagination should render with _label="Label" _on={} _max=2 _page=1
1616
<nav aria-label="Label">
1717
<ul class="navigation-list">
1818
<li>
19-
<kol-button-wc _disabled="" _hidelabel="" _label="kol-page-first" _tooltipalign="top" class="first" exportparts="icon"></kol-button-wc>
19+
<kol-button-wc _disabled="" _hidelabel="" _label="kol-page-first" _tooltipalign="top" class="first"></kol-button-wc>
2020
</li>
2121
<li>
22-
<kol-button-wc _disabled="" _hidelabel="" _label="kol-page-back" _tooltipalign="top" class="previous" exportparts="icon"></kol-button-wc>
22+
<kol-button-wc _disabled="" _hidelabel="" _label="kol-page-back" _tooltipalign="top" class="previous"></kol-button-wc>
2323
</li>
2424
<li>
25-
<kol-button-wc _disabled="" _label="" class="selected">
26-
<span slot="expert">
27-
<span class="visually-hidden">
28-
kol-page
29-
</span>
30-
1
31-
</span>
32-
</kol-button-wc>
25+
<kol-button-wc _ariadescription="kol-page" _disabled="" _label="1" aria-current="page" class="selected"></kol-button-wc>
3326
</li>
3427
<li>
35-
<kol-button-wc _label="" exportparts="icon">
36-
<span slot="expert">
37-
<span class="visually-hidden">
38-
kol-page
39-
</span>
40-
2
41-
</span>
42-
</kol-button-wc>
28+
<kol-button-wc _ariadescription="kol-page" _label="2"></kol-button-wc>
4329
</li>
4430
<li>
45-
<kol-button-wc _hidelabel="" _label="kol-page-next" _tooltipalign="top" class="next" exportparts="icon"></kol-button-wc>
31+
<kol-button-wc _hidelabel="" _label="kol-page-next" _tooltipalign="top" class="next"></kol-button-wc>
4632
</li>
4733
<li>
48-
<kol-button-wc _hidelabel="" _label="kol-page-last" _tooltipalign="top" class="last" exportparts="icon"></kol-button-wc>
34+
<kol-button-wc _hidelabel="" _label="kol-page-last" _tooltipalign="top" class="last"></kol-button-wc>
4935
</li>
5036
</ul>
5137
</nav>

0 commit comments

Comments
 (0)