Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Martin <6279703+deleonio@users.noreply.github.com>

Author: deleonio

packages/tools/kolibri-cli/test/cli-interface.spec.ts

@@ -15,7 +15,7 @@ describe('CLI interface', () => {
                 const cwd = process.cwd();
                 process.chdir(tmpDir);
 
-                const typedBem = require('typed-bem/scss');
+                import * as typedBem from 'typed-bem/scss';
                 const original = typedBem.generateBemScssFile;
                 const calls: string[] = [];
                 typedBem.generateBemScssFile = (_: unknown, name: string) => { calls.push(name); };

packages/tools/kolibri-cli/test/exec-task.spec.ts

@@ -3,7 +3,7 @@ import { ExecTask } from '../src/migrate/runner/tasks/common/ExecTask';
 
 describe('ExecTask', () => {
     it('executes given command', () => {
-        const cp = require('child_process');
+        import * as cp from 'child_process';
         const original = cp.execSync;
         let called = '';
         cp.execSync = (cmd: string) => {

packages/tools/kolibri-cli/test/handle-dependency.spec.ts

@@ -4,7 +4,7 @@ import { HandleDependencyTask } from '../src/migrate/runner/tasks/common/HandleD
 
 describe('HandleDependencyTask', () => {
         it('calls package manager with dependencies', async () => {
-                const childProc = require('child_process');
+                import * as childProc from 'child_process';
                 const original = childProc.execSync;
                 let commands: string[] = [];
                 childProc.execSync = (cmd: string) => { commands.push(cmd); return Buffer.from(''); };

packages/tools/kolibri-cli/test/json-task.spec.ts

@@ -16,6 +16,6 @@ describe('JsonTask', () => {
 
                 process.chdir(cwd);
                 const pkg = JSON.parse(fs.readFileSync(path.join(tmpDir, 'package.json'), 'utf8'));
-                assert.equal(pkg.test, 'mocha');
+                assert.equal(pkg.scripts.test, 'mocha');
         });
 });

packages/tools/kolibri-cli/test/rename-slot.spec.ts

@@ -18,6 +18,6 @@ describe('RenameSlotNameTask', () => {
                 const tsxContent = fs.readFileSync(tsxPath, 'utf8');
                 const htmlContent = fs.readFileSync(htmlPath, 'utf8');
                 assert.ok(tsxContent.includes('slot="header-right"'));
-                assert.ok(htmlContent.includes('slot="header"'));
+                assert.ok(htmlContent.includes('slot="header-right"'));
         });
 });

packages/tools/kolibri-cli/test/tsconfig-reconfigure.spec.ts

@@ -16,6 +16,6 @@ describe('TsConfigReconfigureTask', () => {
 
                 process.chdir(cwd);
                 const config = JSON.parse(fs.readFileSync(path.join(tmpDir, 'tsconfig.json'), 'utf8'));
-                assert.equal(config.target, 'ESNext');
+                assert.equal(config.compilerOptions.target, 'ESNext');
         });
 });