Skip to content

Commit daba8fc

Browse files
committed
Refactor drawer layout: move close button to slot and set full width/height
Refs: #7487
1 parent 70a7e45 commit daba8fc

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

packages/components/src/components/drawer/style.scss

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,27 +19,43 @@
1919
left: 0;
2020
height: 100vh;
2121
max-height: 100%;
22+
23+
.drawer__content {
24+
height: 100%;
25+
}
2226
}
2327

2428
&--right {
2529
top: 0;
2630
right: 0;
2731
height: 100vh;
2832
max-height: 100%;
33+
34+
.drawer__content {
35+
height: 100%;
36+
}
2937
}
3038

3139
&--top {
3240
left: 0;
3341
top: 0;
3442
width: 100vw;
3543
max-width: 100%;
44+
45+
.drawer__content {
46+
width: 100%;
47+
}
3648
}
3749

3850
&--bottom {
3951
left: 0;
4052
bottom: 0;
4153
width: 100vw;
4254
max-width: 100%;
55+
56+
.drawer__content {
57+
width: 100%;
58+
}
4359
}
4460
}
4561

packages/samples/react/src/components/drawer/basic.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ export const DrawerBasic: FC = () => {
3939
Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam
4040
voluptua.
4141
</p>
42+
<KolButton _label="Close drawer" _on={{ onClick: () => drawerElement.current?.close() }} />
4243
</div>
43-
<KolButton _label="Close drawer" _on={{ onClick: () => drawerElement.current?.close() }} />
4444
</KolDrawer>
4545
<KolButton _label="Open drawer" _on={{ onClick: () => drawerElement.current?.open() }} />
4646
<KolDrawer
@@ -55,8 +55,8 @@ export const DrawerBasic: FC = () => {
5555
Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam
5656
voluptua.
5757
</p>
58+
<KolButton _label="Close drawer modal" _on={{ onClick: () => drawerModalElement.current?.close() }} />
5859
</div>
59-
<KolButton _label="Close drawer modal" _on={{ onClick: () => drawerModalElement.current?.close() }} />
6060
</KolDrawer>
6161
<KolButton _label="Open drawer as modal" _on={{ onClick: () => drawerModalElement.current?.open() }} />
6262
</div>

0 commit comments

Comments
 (0)