Adds synchronous RPM Upload API

closes: #4027

Author: dkliban

CHANGES/4027.feature

@@ -0,0 +1 @@
+Added a synchronous RPM upload API. It's available at /pulp/api/v3/content/rpm/packages/upload/.

pulp_rpm/app/serializers/__init__.py

@@ -26,7 +26,7 @@
     ModulemdDefaultsSerializer,
     ModulemdObsoleteSerializer,
 )
-from .package import PackageSerializer, MinimalPackageSerializer  # noqa
+from .package import PackageSerializer, PackageUploadSerializer, MinimalPackageSerializer  # noqa
 from .prune import PrunePackagesSerializer  # noqa
 from .repository import (  # noqa
     CopySerializer,

pulp_rpm/app/serializers/package.py

@@ -1,12 +1,17 @@
+import createrepo_c as cr
 import logging
 import traceback
 from gettext import gettext as _
 
+from django.conf import settings
+from django.db import DatabaseError
 from drf_spectacular.utils import extend_schema_serializer
 from rest_framework import serializers
 from rest_framework.exceptions import NotAcceptable
 
+from pulpcore.plugin.models import Artifact, PulpTemporaryFile
 from pulpcore.plugin.serializers import (
+    ArtifactSerializer,
     ContentChecksumSerializer,
     SingleArtifactContentUploadSerializer,
 )
@@ -382,3 +387,67 @@ class Meta:
             "checksum_type",
         )
         model = Package
+
+
+class PackageUploadSerializer(PackageSerializer):
+    """
+    Serializer for requests to synchronously upload RPM packages.
+    """
+
+    class Meta(PackageSerializer.Meta):
+        # This API does not support uploading to a repository
+        fields = tuple(f for f in PackageSerializer.Meta.fields if f != "repository")
+        model = Package
+        # Name used for the OpenAPI request object
+        ref_name = "PackageUpload"
+
+    def validate(self, data):
+        uploaded_file = data.get("file")
+        # export META from rpm and prepare dict as saveable format
+        try:
+            cr_object = cr.package_from_rpm(
+                uploaded_file.file.name, changelog_limit=settings.KEEP_CHANGELOG_LIMIT
+            )
+            new_pkg = Package.createrepo_to_dict(cr_object)
+        except OSError as e:
+            log.info(traceback.format_exc())
+            raise NotAcceptable(detail="RPM file cannot be parsed for metadata") from e
+
+        # Get or create the Artifact
+        if "file" in data:
+            file = data.pop("file")
+            # if artifact already exists, let's use it
+            try:
+                artifact = Artifact.objects.get(
+                    sha256=file.hashers["sha256"].hexdigest(), pulp_domain=get_domain_pk()
+                )
+                if not artifact.pulp_domain.get_storage().exists(artifact.file.name):
+                    artifact.file = file
+                    artifact.save()
+                else:
+                    artifact.touch()
+            except (Artifact.DoesNotExist, DatabaseError):
+                artifact_data = {"file": file}
+                serializer = ArtifactSerializer(data=artifact_data)
+                serializer.is_valid(raise_exception=True)
+                artifact = serializer.save()
+            data["artifact"] = artifact
+
+        filename = (
+            format_nvra(
+                new_pkg["name"],
+                new_pkg["version"],
+                new_pkg["release"],
+                new_pkg["arch"],
+            )
+            + ".rpm"
+        )
+
+        if not data.get("relative_path"):
+            data["relative_path"] = filename
+            new_pkg["location_href"] = filename
+        else:
+            new_pkg["location_href"] = data["relative_path"]
+
+        data.update(new_pkg)
+        return data

pulp_rpm/app/viewsets/package.py

@@ -1,3 +1,4 @@
+from django.db import transaction
 from django_filters import CharFilter
 from drf_spectacular.utils import extend_schema
 from pulpcore.plugin.models import PulpTemporaryFile
@@ -8,10 +9,17 @@
     OperationPostponedResponse,
     SingleArtifactContentUploadViewSet,
 )
+from rest_framework import status
+from rest_framework.decorators import action
+from rest_framework.response import Response
 
 from pulp_rpm.app import tasks as rpm_tasks
 from pulp_rpm.app.models import Package
-from pulp_rpm.app.serializers import MinimalPackageSerializer, PackageSerializer
+from pulp_rpm.app.serializers import (
+    MinimalPackageSerializer,
+    PackageSerializer,
+    PackageUploadSerializer,
+)
 
 
 class PackageFilter(ContentFilter):
@@ -127,3 +135,22 @@ def create(self, request):
             },
         )
         return OperationPostponedResponse(task, request)
+
+    @extend_schema(
+        description="Synchronously upload an RPM package.",
+        request=PackageUploadSerializer,
+        responses={201: PackageSerializer},
+        summary="Upload an RPM package synchronously.",
+    )
+    @action(detail=False, methods=["post"], serializer_class=PackageUploadSerializer)
+    def upload(self, request):
+        """Create an RPM package."""
+        serializer = self.get_serializer(data=request.data)
+        with transaction.atomic():
+            # Create the artifact
+            serializer.is_valid(raise_exception=True)
+            # Create the Package
+            serializer.save()
+
+        headers = self.get_success_headers(serializer.data)
+        return Response(serializer.data, status=status.HTTP_201_CREATED, headers=headers)

pulp_rpm/tests/functional/api/test_upload.py

@@ -206,6 +206,39 @@ def test_upload_comps_xml_into_repo_replace(
     eval_counts(vers_resp.content_summary.added, is_small=False)
 
 
+def test_synchronous_package_upload(
+    delete_orphans_pre, rpm_package_api, monitor_task, pulpcore_bindings
+):
+    """Test synchronously uploading an RPM.
+
+    1. Upload a unit
+    2. Attempt to upload same unit with different labels
+    3. Assert that labels don't change.
+    """
+    # Single unit upload
+    file_to_use = os.path.join(RPM_UNSIGNED_FIXTURE_URL, RPM_PACKAGE_FILENAME)
+
+    labels = {"key_1": "value_1"}
+    with NamedTemporaryFile() as file_to_upload:
+        file_to_upload.write(requests.get(file_to_use).content)
+        upload_attrs = {"file": file_to_upload.name, "pulp_labels": labels}
+        package = rpm_package_api.upload(**upload_attrs)
+
+    assert package.location_href == RPM_PACKAGE_FILENAME
+    assert package.pulp_labels == labels
+
+    # Duplicate unit
+    with NamedTemporaryFile() as file_to_upload:
+        new_labels = {"key_2": "value_2"}
+        file_to_upload.write(requests.get(file_to_use).content)
+        upload_attrs = {"file": file_to_upload.name, "pulp_labels": new_labels}
+        duplicate_package = rpm_package_api.upload(**upload_attrs)
+
+    assert duplicate_package.pulp_href == package.pulp_href
+    assert duplicate_package.pulp_labels == package.pulp_labels
+    assert duplicate_package.pulp_labels != new_labels
+
+
 def eval_resources(resources, is_small=True):
     """Eval created_resources counts."""
     groups = [g for g in resources if "packagegroups" in g]