Deprecate a ORM filter on tasks

Filtering tasks with `reserved_resources_record__resource` should be replaced
by `reserved_resources_record__contains`.

ref #8501

Author: mdellweg

CHANGES/plugin_api/8501.deprecation

@@ -0,0 +1,2 @@
+Deprecate the use of the `reserved_resources_record__resource` in favor of `reserved_resources_record__contains`.
+Tentative removal release is pulpcore==3.15.

docs/plugins/plugin-writer/concepts/index.rst

@@ -400,8 +400,8 @@ In 3.8 the following changes happen:
 2. The existing method signature ``def foo(a, b)`` is left in-tact.
 3. The ``foo`` method would have the a Python ``DeprecationWarning`` added to it such as::
 
-    from pulpcore.app.logging import deprecation_logger
-    deprecation_logger.warn("foo() is deprecated and will be removed in pulpcore==3.9; use the_new_foo().")
+    from pulpcore.app.loggers import deprecation_logger
+    deprecation_logger.warning("foo() is deprecated and will be removed in pulpcore==3.9; use the_new_foo().")
 
 4. A ``CHANGES/plugin_api/XXXX.deprecation`` changelog entry is created explaining how to port
    plugin code onto the new call interface.

pulpcore/app/migrations/0065_merge_20210615_1211.py

@@ -0,0 +1,14 @@
+# Generated by Django 2.2.24 on 2021-06-15 12:11
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('core', '0064_repository_user_hidden'),
+        ('core', '0064_add_new_style_task_columns'),
+    ]
+
+    operations = [
+    ]

pulpcore/app/models/task.py

@@ -24,6 +24,7 @@
 from pulpcore.constants import TASK_CHOICES, TASK_FINAL_STATES, TASK_STATES
 from pulpcore.exceptions import AdvisoryLockError, exception_to_dict
 from pulpcore.tasking.constants import TASKING_CONSTANTS
+from pulpcore.app.loggers import deprecation_logger
 
 _logger = logging.getLogger(__name__)
 
@@ -212,6 +213,19 @@ def _hash_to_u64(value):
     return int.from_bytes(_digest, byteorder="big", signed=True)
 
 
+class TaskManager(models.Manager):
+    def filter(self, *args, **kwargs):
+        value = kwargs.pop("reserved_resources_record__resource", None)
+        if value is not None:
+            deprecation_logger.warning(
+                "Filtering tasks with 'reserved_resources_record__resource' is deprecated"
+                " and may be removed as soon as pulpcore==3.15;"
+                " use 'reserved_resources_record__contains' with a list of values instead."
+            )
+            kwargs["reserved_resources_record__contains"] = [value]
+        return super().filter(*args, **kwargs)
+
+
 class Task(BaseModel, AutoDeleteObjPermsMixin, AutoAddObjPermsMixin):
     """
     Represents a task
@@ -236,6 +250,8 @@ class Task(BaseModel, AutoDeleteObjPermsMixin, AutoAddObjPermsMixin):
         worker (models.ForeignKey): The worker that this task is in
     """
 
+    objects = TaskManager()
+
     state = models.TextField(choices=TASK_CHOICES)
     name = models.TextField()
     logging_cid = models.CharField(max_length=256, db_index=True, default="")