Merge pull request #2063 from puppetlabs/FACT-2777

(FACT-2777) Fix lsbdist facts on ubuntu

Author: oanatmaria

lib/facter/facts/ubuntu/lsbdistrelease.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module Facts
+  module Ubuntu
+    class Lsbdistrelease
+      FACT_NAME = 'lsbdistrelease'
+      ALIASES = %w[lsbmajdistrelease lsbminordistrelease].freeze
+      TYPE = :legacy
+
+      def call_the_resolver
+        fact_value = Facter::Resolvers::LsbRelease.resolve(:release)
+
+        return Facter::ResolvedFact.new(FACT_NAME, nil, :legacy) unless fact_value
+
+        version = fact_value.split('.')
+
+        [Facter::ResolvedFact.new(FACT_NAME, fact_value, :legacy),
+         Facter::ResolvedFact.new(ALIASES[0], version[0], :legacy),
+         Facter::ResolvedFact.new(ALIASES[1], version[1], :legacy)]
+      end
+    end
+  end
+end

spec/facter/facts/ubuntu/lsbdistrelease_spec.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+describe Facts::Ubuntu::Lsbdistrelease do
+  describe '#call_the_resolver' do
+    subject(:fact) { Facts::Ubuntu::Lsbdistrelease.new }
+
+    context 'when lsb-release is installed' do
+      before do
+        allow(Facter::Resolvers::LsbRelease).to receive(:resolve).with(:release).and_return(value)
+      end
+
+      context 'when version_id is retrieved successful' do
+        let(:value) { '18.04' }
+        let(:value_final) { { 'full' => '18.04', 'major' => '18', 'minor' => '04' } }
+
+        it 'calls Facter::Resolvers::LsbRelease with :name' do
+          fact.call_the_resolver
+          expect(Facter::Resolvers::LsbRelease).to have_received(:resolve).with(:release)
+        end
+
+        it 'returns release fact' do
+          expect(fact.call_the_resolver).to be_an_instance_of(Array).and \
+            contain_exactly(an_object_having_attributes(name: 'lsbdistrelease', value: value, type: :legacy),
+                            an_object_having_attributes(name: 'lsbmajdistrelease',
+                                                        value: value_final['major'], type: :legacy),
+                            an_object_having_attributes(name: 'lsbminordistrelease',
+                                                        value: value_final['minor'], type: :legacy))
+        end
+      end
+
+      context 'when Debian 10' do
+        let(:value) { '10' }
+        let(:value_final) { { 'full' => '10', 'major' => '10', 'minor' => nil } }
+
+        it 'calls Facter::Resolvers::LsbRelease with :name' do
+          fact.call_the_resolver
+          expect(Facter::Resolvers::LsbRelease).to have_received(:resolve).with(:release)
+        end
+
+        it 'returns release fact' do
+          expect(fact.call_the_resolver).to be_an_instance_of(Array).and \
+            contain_exactly(an_object_having_attributes(name: 'lsbdistrelease', value: value, type: :legacy),
+                            an_object_having_attributes(name: 'lsbmajdistrelease',
+                                                        value: value_final['major'], type: :legacy),
+                            an_object_having_attributes(name: 'lsbminordistrelease',
+                                                        value: value_final['minor'], type: :legacy))
+        end
+      end
+
+      context 'when lsb-release is not installed' do
+        let(:value) { nil }
+
+        it 'returns release fact as nil' do
+          expect(fact.call_the_resolver).to be_an_instance_of(Facter::ResolvedFact).and \
+            have_attributes(name: 'lsbdistrelease', value: value, type: :legacy)
+        end
+      end
+    end
+  end
+end