add more tests

Author: bwitt

spec/unit/puppet/provider/ini_setting/ruby_spec.rb

@@ -1674,5 +1674,61 @@ def self.file_path
       provider.create
       validate_file(expected_content_four, tmpfile)
     end
+
+    expected_content_five = <<-EOS
+[section]
+bar = barvalue
+
+[section2]
+foo = value
+bar = barvalue
+foo = value2
+
+[section3]
+    EOS
+
+    it 'removes a multi-value setting with ensure => absent' do
+      resource = Puppet::Type::Ini_setting.new(common_params.merge(section: 'section', setting: 'foo', ensure: 'absent'))
+      provider = described_class.new(resource)
+      expect(provider.exists?).to be true
+      provider.destroy
+      validate_file(expected_content_five, tmpfile)
+    end
+
+    expected_content_six = <<-EOS
+[section]
+foo = foovalue
+foo = foovalue2
+foo = foovalue3
+foo = foovalue4
+bar = barvalue
+
+[section2]
+foo = value
+bar = barvalue
+foo = value2
+
+[section3]
+baz = newvalue
+    EOS
+
+    it 'correctly updates section3 line numbers after modifying section with multi-values' do
+      # First reduce section's foo from 4 values to 1, then add to section3
+      resource1 = Puppet::Type::Ini_setting.new(common_params.merge(section: 'section', setting: 'foo', value: 'foovalue'))
+      provider1 = described_class.new(resource1)
+      provider1.create
+
+      # Re-read the file with new provider to add setting to section3
+      resource2 = Puppet::Type::Ini_setting.new(common_params.merge(section: 'section3', setting: 'baz', value: 'newvalue'))
+      provider2 = described_class.new(resource2)
+      provider2.create
+
+      # Now reset file and do both operations to verify section line tracking
+      File.write(tmpfile, orig_content)
+      resource3 = Puppet::Type::Ini_setting.new(common_params.merge(section: 'section3', setting: 'baz', value: 'newvalue'))
+      provider3 = described_class.new(resource3)
+      provider3.create
+      validate_file(expected_content_six, tmpfile)
+    end
   end
 end

spec/unit/puppet/provider/ini_subsetting/ruby_spec.rb

@@ -360,4 +360,60 @@ def validate_file(expected_content, tmpfile)
       expect(validate_file(expected_content_two, tmpfile)).to be_truthy
     end
   end
+
+  context 'when the parent setting has multiple values (same key repeated)' do
+    let(:common_params) do
+      {
+        title: 'ini_subsetting_multivalue_test',
+        path: tmpfile,
+        section: 'main',
+        key_val_separator: '=',
+      }
+    end
+
+    let(:orig_content) do
+      <<-INIFILE
+        [main]
+        setting="value1 value2"
+        setting="value3 value4"
+        other=data
+      INIFILE
+    end
+
+    it 'reads subsetting from the first occurrence of a multi-value key' do
+      resource = Puppet::Type::Ini_subsetting.new(common_params.merge(setting: 'setting', subsetting: 'value1', quote_char: '"'))
+      provider = described_class.new(resource)
+      expect(provider.exists?).to eq ''
+    end
+
+    # NOTE: When ini_subsetting modifies a key that has multiple values,
+    # it collapses them to a single value (the first one, modified).
+    # This is expected behavior per the multi-value PR design.
+    expected_content_one = <<-INIFILE
+        [main]
+        setting="value1 value2 newval"
+        other=data
+    INIFILE
+
+    it 'modifies the first occurrence and collapses multi-value keys when adding a subsetting' do
+      resource = Puppet::Type::Ini_subsetting.new(common_params.merge(setting: 'setting', subsetting: 'newval', value: '', quote_char: '"'))
+      provider = described_class.new(resource)
+      expect(provider.exists?).to be_nil
+      provider.create
+      validate_file(expected_content_one, tmpfile)
+    end
+
+    expected_content_two = <<-INIFILE
+        [main]
+        setting="value2"
+        other=data
+    INIFILE
+
+    it 'removes a subsetting and collapses multi-value keys' do
+      resource = Puppet::Type::Ini_subsetting.new(common_params.merge(setting: 'setting', subsetting: 'value1', quote_char: '"'))
+      provider = described_class.new(resource)
+      provider.destroy
+      validate_file(expected_content_two, tmpfile)
+    end
+  end
 end