Merge pull request #184 from glarizza/MODULES_2369_key_val_separator

[MODULES-2369] Support a space as a key_val_separator

Author: jonnytdevops

lib/puppet/util/ini_file.rb

@@ -7,7 +7,7 @@ class IniFile
 
     def initialize(path, key_val_separator = ' = ', section_prefix = '[', section_suffix = ']')
 
-      k_v_s = key_val_separator.strip
+      k_v_s = key_val_separator =~ /^\s+$/ ? ' ' : key_val_separator.strip
 
       @section_prefix = section_prefix
       @section_suffix = section_suffix

spec/acceptance/ini_setting_spec.rb

@@ -262,6 +262,8 @@
         ""                             => /two = three/,
         "key_val_separator => '=',"    => /two=three/,
         "key_val_separator => ' =  '," => /two =  three/,
+        "key_val_separator => ' '," => /two three/,
+        "key_val_separator => '   '," => /two   three/,
     }.each do |parameter, content|
       context "with \"#{parameter}\" makes \"#{content}\"" do
         pp = <<-EOS

spec/unit/puppet/provider/ini_setting/ruby_spec.rb

@@ -783,6 +783,49 @@ def self.file_path
 
   end
 
+  context "when overriding the separator to a space" do
+    let(:orig_content) {
+      <<-EOS
+[section2]
+foo bar
+      EOS
+    }
+
+    it "should modify an existing setting" do
+      resource = Puppet::Type::Ini_setting.new(common_params.merge(
+                                                   :section           => 'section2',
+                                                   :setting           => 'foo',
+                                                   :value             => 'yippee',
+                                                   :key_val_separator => ' '))
+      provider = described_class.new(resource)
+      provider.exists?.should be true
+      provider.value.should == 'bar'
+      provider.value=('yippee')
+      validate_file(<<-EOS
+[section2]
+foo yippee
+      EOS
+      )
+    end
+
+    it "should add a new setting" do
+      resource = Puppet::Type::Ini_setting.new(common_params.merge(
+                                                   :section           => 'section2',
+                                                   :setting           => 'bar',
+                                                   :value             => 'baz',
+                                                   :key_val_separator => ' '))
+      provider = described_class.new(resource)
+      provider.exists?.should be false
+      provider.create
+      validate_file(<<-EOS
+[section2]
+foo bar
+bar baz
+      EOS
+      )
+    end
+  end
+
   context "when ensuring that a setting is absent" do
     let(:orig_content) {
       <<-EOS