(maint) Use agent facts when removing SQL instances

 - Previously the test that removes instance was hard-coded to use
   'MSSQLSERVER', but this makes the test a bit more fragile.

   Instead, use Beaker to load the agents facts, passing the
   module sqlserver/lib/facter directory in via FACTERLIB so that
   the names of all instances can be retrieved.

Author: Iristyle

spec/acceptance/sqlserver_features_spec.rb

@@ -241,9 +241,12 @@ def bind_and_apply_failing_manifest(host, features, ensure_val = 'present')
       features = ['Tools', 'BC', 'Conn', 'SSMS', 'ADV_SSMS', 'SDK', 'IS', 'MDS']
 
       before(:all) do
-        # this assumes that only default MSSQLSERVER has been installed so far
-        # be careful about running tests out of sequence
-        remove_sql_instances(host, {:version => version, :instance_names => ['MSSQLSERVER']})
+        # use agents fact to get instance names
+        distmoduledir = on(host, "echo #{host['distmoduledir']}").raw_output.chomp
+        facter_opts = {:environment => {'FACTERLIB' => "#{distmoduledir}/sqlserver/lib/facter" }}
+
+        names = eval(fact_on(host, 'sqlserver_instances', facter_opts)).values.inject(:merge).keys
+        remove_sql_instances(host, {:version => version, :instance_names => names})
       end
 
       after(:all) do