Update deprecation tests to include future parser

Author: Helen Campbell

spec/functions/deprecation_spec.rb

@@ -41,11 +41,14 @@
     }
   end
 else
+  # Puppet version < 4 will use these tests.
   describe 'deprecation' do
     after(:all) do
       ENV.delete('STDLIB_LOG_DEPRECATIONS')
     end
-    ENV['STDLIB_LOG_DEPRECATIONS'] = "true"
+    before(:all) do
+      ENV['STDLIB_LOG_DEPRECATIONS'] = "true"
+    end
     it { is_expected.not_to eq(nil) }
     it { is_expected.to run.with_params().and_raise_error(Puppet::ParseError, /wrong number of arguments/i) }
 
@@ -54,4 +57,21 @@
       is_expected.to run.with_params('key', 'heelo')
     end
   end
+  # Tests the Puppet 3 setup with future parser enabled.
+  if ENV['FUTURE_PARSER'] = "true"
+    describe 'deprecation' do
+    after(:all) do
+      ENV.delete('STDLIB_LOG_DEPRECATIONS')
+    end
+    before(:all) do
+      ENV['STDLIB_LOG_DEPRECATIONS'] = "true"
+    end
+      it { is_expected.not_to eq(nil) }
+      it { is_expected.to run.with_params().and_raise_error(Puppet::ParseError, /wrong number of arguments/i) }
+      it 'should display a single warning' do
+        scope.expects(:warning).with(includes('heelo'))
+        is_expected.to run.with_params('key', 'heelo')
+      end
+    end
+  end
 end