add port types

Author: b4ldr

README.md

@@ -413,6 +413,90 @@ Unacceptable input example:
 /usr2/username/bin:/usr/local/bin:/usr/bin:.
 ```
 
+#### `Stdlib::Port`
+
+Matches a valid TCP/UDP Port number
+
+Acceptable input examples:
+
+```shell
+80
+
+443
+
+1337
+
+65000
+```
+
+Unacceptable input example:
+
+```shell
+-1
+
+65536
+
+'443'
+
+'https'
+````
+
+#### `Stdlib::Privilegedport`
+
+Matches a valid TCP/UDP Pivlaged port i.e. < 1024
+
+Acceptable input examples:
+
+```shell
+80
+
+443
+
+1023
+```
+
+Unacceptable input example:
+
+```shell
+-1
+
+1337
+
+'443'
+
+'https'
+```
+
+#### `Stdlib::Unprivilegedport`
+
+Matches a valid TCP/UDP Pivlaged port i.e. >= 1024
+
+Acceptable input examples:
+
+```shell
+1024
+
+1337
+
+65000
+```
+
+Unacceptable input example:
+
+```shell
+-1
+
+80
+
+443
+
+1023
+
+'443'
+
+'https'
+```
+
 ### Facts
 
 #### `package_provider`

spec/aliases/port_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+if Puppet::Util::Package.versioncmp(Puppet.version, '4.5.0') >= 0
+  describe 'test::port', type: :class do
+    describe 'valid ports' do
+      [ 
+        80,
+        443,
+        1337,
+        65000
+      ].each do |value|
+        describe value.inspect do
+          let(:params) { { value: value } }
+          it { is_expected.to compile }
+        end
+      end
+    end
+
+    describe 'invalid path handling' do
+      context 'garbage inputs' do
+        [
+          nil,
+          [nil],
+          [nil, nil],
+          { 'foo' => 'bar' },
+          {},
+          '',
+          'https',
+          '443',
+          -1,
+          65536
+        ].each do |value|
+          describe value.inspect do
+            let(:params) { { value: value } }
+            it { is_expected.to compile.and_raise_error(%r{parameter 'value' expects a Stdlib::Port}) }
+          end
+        end
+      end
+    end
+  end
+end

spec/aliases/privilegedport_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+if Puppet::Util::Package.versioncmp(Puppet.version, '4.5.0') >= 0
+  describe 'test::privilegedport', type: :class do
+    describe 'valid ports' do
+      [ 
+        80,
+        443,
+        1023
+      ].each do |value|
+        describe value.inspect do
+          let(:params) { { value: value } }
+          it { is_expected.to compile }
+        end
+      end
+    end
+
+    describe 'invalid path handling' do
+      context 'garbage inputs' do
+        [
+          nil,
+          [nil],
+          [nil, nil],
+          { 'foo' => 'bar' },
+          {},
+          '',
+          'https',
+          '443',
+          -1,
+          1337,
+          1024
+        ].each do |value|
+          describe value.inspect do
+            let(:params) { { value: value } }
+            it { is_expected.to compile.and_raise_error(%r{parameter 'value' expects a Stdlib::Privilegedport}) }
+          end
+        end
+      end
+    end
+  end
+end

spec/aliases/unprivilegedport_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper'
+
+if Puppet::Util::Package.versioncmp(Puppet.version, '4.5.0') >= 0
+  describe 'test::unprivilegedport', type: :class do
+    describe 'valid unprivilegedport' do
+      [ 
+        1024,
+        1337,
+        65000
+      ].each do |value|
+        describe value.inspect do
+          let(:params) { { value: value } }
+          it { is_expected.to compile }
+        end
+      end
+    end
+
+    describe 'invalid path handling' do
+      context 'garbage inputs' do
+        [
+          nil,
+          [nil],
+          [nil, nil],
+          { 'foo' => 'bar' },
+          {},
+          '',
+          'https',
+          '443',
+          -1,
+          80,
+          443,
+          1023
+        ].each do |value|
+          describe value.inspect do
+            let(:params) { { value: value } }
+            it { is_expected.to compile.and_raise_error(%r{parameter 'value' expects a Stdlib::Unprivilegedport}) }
+          end
+        end
+      end
+    end
+  end
+end

spec/fixtures/test/manifests/port.pp

@@ -0,0 +1,6 @@
+# Class to test the Stdlib::Port type alias
+class test::port(
+  Stdlib::Port $value,
+  ) {
+    notice("Success")
+  }

spec/fixtures/test/manifests/privilegedport.pp

@@ -0,0 +1,6 @@
+# Class to test the Stdlib::Privilegedport type alias
+class test::privilegedport(
+  Stdlib::Privilegedport $value,
+  ) {
+    notice("Success")
+  }

spec/fixtures/test/manifests/unprivilegedport.pp

@@ -0,0 +1,6 @@
+# Class to test the Stdlib::Unprivilegedport type alias
+class test::unprivilegedport(
+  Stdlib::Unprivilegedport $value,
+  ) {
+    notice("Success")
+  }

types/port.pp

@@ -0,0 +1 @@
+type Stdlib::Port = Integer[0, 65535]

types/privilegedport.pp

@@ -0,0 +1 @@
+type Stdlib::Privilegedport = Integer[1, 1023]

types/unprivilegedport.pp

@@ -0,0 +1 @@
+type Stdlib::Unprivilegedport = Integer[1024, 65535]