Fix crash on plistlib.py

Author: Pierre-Sassoulas

pylint/checkers/exceptions.py

@@ -336,12 +336,9 @@ def _check_raise_missing_from(self, node: nodes.Raise) -> None:
             # The `except` doesn't have an `as exception:` part, meaning there's no way that
             # the `raise` is raising the same exception.
             class_of_old_error = "Exception"
-            if isinstance(containing_except_node.type, nodes.Name):
-                class_of_old_error = containing_except_node.type.name
-            elif isinstance(containing_except_node.type, nodes.Tuple):
-                # I.e. 'except (ZeroDivisionError, ValueError, ArithmeticError)'
-                exceptions = ", ".join(n.name for n in containing_except_node.type.elts)
-                class_of_old_error = f"({exceptions})"
+            if isinstance(containing_except_node.type, (nodes.Name, nodes.Tuple)):
+                # 'except ZeroDivisionError' or 'except (ZeroDivisionError, ValueError)'
+                class_of_old_error = containing_except_node.type.as_string()
             self.add_message(
                 "raise-missing-from",
                 node=node,

tests/functional/r/raise_missing_from.py

@@ -74,9 +74,12 @@
         # +1: [raise-missing-from]
         raise KeyError(whatever, overever=12)
 
-
-################################################################################
-# Negatives (Same cases as above, except with `from`):
+try:
+    # Taken from https://github.com/python/cpython/blob/3.10/Lib/plistlib.py#L459
+    pass
+except (OSError, IndexError, struct.error, OverflowError,
+        ValueError):
+    raise InvalidFileException()  # [raise-missing-from]
 
 try:
     1 / 0
@@ -123,10 +126,6 @@
 except ZeroDivisionError as e:
     raise KeyError(whatever, whatever=whatever) from foo
 
-
-################################################################################
-# Other negatives:
-
 try:
     1 / 0
 except ZeroDivisionError:

tests/functional/r/raise_missing_from.txt

@@ -8,3 +8,4 @@ raise-missing-from:54:4:54:20::Consider explicitly re-raising using 'raise KeyEr
 raise-missing-from:60:4:60:47::Consider explicitly re-raising using 'raise KeyError(whatever, whatever=whatever) from e':HIGH
 raise-missing-from:72:16:72:59::Consider explicitly re-raising using 'except (ZeroDivisionError, ValueError, KeyError) as exc' and 'raise KeyError(whatever, whatever=whatever) from exc':HIGH
 raise-missing-from:75:8:75:45::Consider explicitly re-raising using 'except (ZeroDivisionError, ValueError, KeyError) as exc' and 'raise KeyError(whatever, overever=12) from exc':HIGH
+raise-missing-from:82:4:82:32::Consider explicitly re-raising using 'except (OSError, IndexError, struct.error, OverflowError, ValueError) as exc' and 'raise InvalidFileException() from exc':HIGH