implement review suggestions

Author: clavedeluna

pylint/checkers/nested_min_max.py

@@ -9,15 +9,22 @@
 import copy
 from typing import TYPE_CHECKING
 
-from astroid import nodes
+from astroid import nodes, objects
 
 from pylint.checkers import BaseChecker
-from pylint.checkers.utils import DICT_TYPES, only_required_for_messages, safe_infer
+from pylint.checkers.utils import only_required_for_messages, safe_infer
 from pylint.interfaces import INFERENCE
 
 if TYPE_CHECKING:
     from pylint.lint import PyLinter
 
+DICT_TYPES = (
+    objects.DictValues,
+    objects.DictKeys,
+    objects.DictItems,
+    nodes.node_classes.Dict,
+)
+
 
 class NestedMinMaxChecker(BaseChecker):
     """Multiple nested min/max calls on the same line will raise multiple messages.

pylint/checkers/utils.py

@@ -238,13 +238,6 @@
     {"_sitebuiltins.Quitter", "sys.exit", "posix._exit", "nt._exit"}
 )
 
-DICT_TYPES = (
-    astroid.objects.DictValues,
-    astroid.objects.DictKeys,
-    astroid.objects.DictItems,
-    astroid.nodes.node_classes.Dict,
-)
-
 
 class NoSuchArgumentError(Exception):
     pass

pylint/checkers/variables.py

@@ -108,6 +108,13 @@
     }
 )
 
+DICT_TYPES = (
+    astroid.objects.DictValues,
+    astroid.objects.DictKeys,
+    astroid.objects.DictItems,
+    astroid.nodes.node_classes.Dict,
+)
+
 
 class VariableVisitConsumerAction(Enum):
     """Reported by _check_consumer() and its sub-methods to determine the
@@ -159,7 +166,7 @@ def _get_unpacking_extra_info(node: nodes.Assign, inferred: InferenceResult) ->
     and unbalanced-tuple/dict-unpacking errors.
     """
     more = ""
-    if isinstance(inferred, utils.DICT_TYPES):
+    if isinstance(inferred, DICT_TYPES):
         if isinstance(node, nodes.Assign):
             more = node.value.as_string()
         elif isinstance(node, nodes.For):
@@ -1242,7 +1249,7 @@ def visit_for(self, node: nodes.For) -> None:
         targets = node.target.elts
 
         inferred = utils.safe_infer(node.iter)
-        if not isinstance(inferred, utils.DICT_TYPES):
+        if not isinstance(inferred, DICT_TYPES):
             return
 
         values = self._nodes_to_unpack(inferred)
@@ -2879,7 +2886,7 @@ def _check_unpacking(
     @staticmethod
     def _nodes_to_unpack(node: nodes.NodeNG) -> list[nodes.NodeNG] | None:
         """Return the list of values of the `Assign` node."""
-        if isinstance(node, (nodes.Tuple, nodes.List) + utils.DICT_TYPES):
+        if isinstance(node, (nodes.Tuple, nodes.List) + DICT_TYPES):
             return node.itered()  # type: ignore[no-any-return]
         if isinstance(node, astroid.Instance) and any(
             ancestor.qname() == "typing.NamedTuple" for ancestor in node.ancestors()
@@ -2905,7 +2912,7 @@ def _report_unbalanced_unpacking(
 
         symbol = (
             "unbalanced-dict-unpacking"
-            if isinstance(inferred, utils.DICT_TYPES)
+            if isinstance(inferred, DICT_TYPES)
             else "unbalanced-tuple-unpacking"
         )
         self.add_message(symbol, node=node, args=args, confidence=INFERENCE)

tests/regrtest_data/nested_min_max.py

@@ -1302,21 +1302,6 @@ def test_no_name_in_module(self) -> None:
             [module, "-E"], expected_output="", unexpected_output=unexpected
         )
 
-    def test_nested_min_max_splats(self) -> None:
-        """Test that the nested-min-max message suggests to splat an iterable"""
-        module = join(HERE, "regrtest_data", "nested_min_max.py")
-        expected_str = f"""
-        ************* Module nested_min_max
-        {module}:4:0: W3301: Do not use nested call of 'max'; it's possible to do 'max(3, *lst)' instead (nested-min-max)
-        {module}:7:0: W3301: Do not use nested call of 'max'; it's possible to do 'max(3, *nums)' instead (nested-min-max)
-        {module}:10:0: W3301: Do not use nested call of 'max'; it's possible to do 'max(3, *nums)' instead (nested-min-max)
-        {module}:13:0: W3301: Do not use nested call of 'max'; it's possible to do 'max(3, *nums)' instead (nested-min-max)
-        {module}:15:0: W3301: Do not use nested call of 'max'; it's possible to do 'max(3, *nums.values())' instead (nested-min-max)
-        {module}:18:0: W3301: Do not use nested call of 'max'; it's possible to do 'max(3, *nums, *lst2)' instead (nested-min-max)
-        """  # noqa: E501
-        expected = textwrap.dedent(expected_str)
-        self._test_output([module], expected_output=expected)
-
 
 class TestCallbackOptions:
     """Test for all callback options we support."""