refactor less assignement

Author: Pierre-Sassoulas

pylint/checkers/exceptions.py

@@ -335,20 +335,23 @@ def _check_raise_missing_from(self, node: nodes.Raise) -> None:
         # there's a violation on two simple cases: `raise SomeException(whatever)` and `raise
         # SomeException`.
 
-        need_to_raise = False
-        except_as_exc = ""
-        exception_name = "exc"
         if containing_except_node.name is None:
             # The `except` doesn't have an `as exception:` part, meaning there's no way that
             # the `raise` is raising the same exception.
+            class_of_old_error = "Exception"
             if isinstance(containing_except_node.type, nodes.Name):
                 class_of_old_error = containing_except_node.type.name
             elif isinstance(containing_except_node.type, nodes.Tuple):
                 class_of_old_error = ", ".join(
                     n.name for n in containing_except_node.type.elts
                 )
-            except_as_exc = f"'except {class_of_old_error} as {exception_name}' and "
-            need_to_raise = True
+            except_as_exc = f"'except {class_of_old_error} as exc' and "
+            self.add_message(
+                "raise-missing-from",
+                node=node,
+                args=(except_as_exc, node.as_string(), "exc"),
+                confidence=HIGH,
+            )
         elif (
             isinstance(node.exc, nodes.Call)
             and isinstance(node.exc.func, nodes.Name)
@@ -358,13 +361,10 @@ def _check_raise_missing_from(self, node: nodes.Raise) -> None:
             )
         ):
             # We have a `raise SomeException(whatever)` or a `raise SomeException`
-            exception_name = containing_except_node.name.name
-            need_to_raise = True
-        if need_to_raise:
             self.add_message(
                 "raise-missing-from",
                 node=node,
-                args=(except_as_exc, node.as_string(), exception_name),
+                args=("", node.as_string(), containing_except_node.name.name),
                 confidence=HIGH,
             )