add skip index tests

Author: LeoQuote

src/bandersnatch/mirror.py

@@ -86,8 +86,7 @@ async def synchronize(
             )
 
         await self.sync_packages()
-        if sync_simple_index:
-            self.finalize_sync()
+        self.finalize_sync(sync_index_page=sync_simple_index)
         return self.altered_packages
 
     def _filter_packages(self) -> None:
@@ -167,7 +166,7 @@ async def sync_packages(self) -> None:
             # TODO Remove this check by following packages_to_sync's typing
             self.on_error(e)
 
-    def finalize_sync(self) -> None:
+    def finalize_sync(self, sync_index_page: bool = True) -> None:
         raise NotImplementedError()
 
     def on_error(self, exception: BaseException, **kwargs: Dict) -> None:
@@ -344,8 +343,9 @@ async def process_package(self, package: Package) -> None:
         # Cleanup old legacy non PEP 503 Directories created for the Simple API
         await self.cleanup_non_pep_503_paths(package)
 
-    def finalize_sync(self) -> None:
-        self.sync_index_page()
+    def finalize_sync(self, sync_index_page: bool = True) -> None:
+        if sync_index_page:
+            self.sync_index_page()
         if self.need_wrapup:
             self.wrapup_successful_sync()
         return None

src/bandersnatch/tests/test_mirror.py

@@ -297,6 +297,28 @@ async def test_mirror_empty_resume_from_todo_list(mirror: BandersnatchMirror) ->
     assert open("status").read() == "20"
 
 
+@pytest.mark.asyncio
+async def test_mirror_sync_package_skip_index(mirror: BandersnatchMirror) -> None:
+    mirror.master.all_packages = mock.AsyncMock(return_value={"foo": 1})  # type: ignore
+    mirror.json_save = True
+    # Recall bootstrap so we have the json dirs
+    mirror._bootstrap()
+    await mirror.synchronize(sync_simple_index=False)
+
+    assert """\
+json{0}foo
+last-modified
+packages{0}2.7{0}f{0}foo{0}foo.whl
+packages{0}any{0}f{0}foo{0}foo.zip
+pypi{0}foo{0}json
+simple{0}foo{0}index.html""".format(
+        sep
+    ) == utils.find(
+        mirror.webdir, dirs=False
+    )
+    assert open("status", "rb").read() == b"1"
+
+
 @pytest.mark.asyncio
 async def test_mirror_sync_package(mirror: BandersnatchMirror) -> None:
     mirror.master.all_packages = mock.AsyncMock(return_value={"foo": 1})  # type: ignore