Propagate int-max-str-digits ValueError (#1155)

Author: notatallshaw

src/packaging/version.py

@@ -405,7 +405,13 @@ def __init__(self, version: str) -> None:
             try:
                 self._release = tuple(map(int, version.split(".")))
             except ValueError:
-                raise InvalidVersion(f"Invalid version: {version!r}") from None
+                # Empty parts (from "1..2", ".1", etc.) are invalid versions.
+                # Any other ValueError (e.g. int str-digits limit) should
+                # propagate to the caller.
+                if "" in version.split("."):
+                    raise InvalidVersion(f"Invalid version: {version!r}") from None
+                # TODO: remove "no cover" when Python 3.9 is dropped.
+                raise  # pragma: no cover
 
             self._epoch = 0
             self._pre = None

tests/test_specifiers.py

@@ -7,6 +7,7 @@
 import itertools
 import operator
 import re
+import sys
 import typing
 
 import pytest
@@ -2065,6 +2066,27 @@ def test_contains_rejects_invalid_specifier(
         spec = SpecifierSet(specifier, prereleases=True)
         assert not spec.contains(input)
 
+    @pytest.mark.skipif(
+        not hasattr(sys, "get_int_max_str_digits"),
+        reason="requires int max str digits limit",
+    )
+    @pytest.mark.parametrize(
+        "specifier",
+        [
+            ">=" + "1" * 5000,
+            ">=1.0a" + "1" * 5000,
+        ],
+    )
+    def test_contains_oversized_version_raises_valueerror(self, specifier: str) -> None:
+        old = sys.get_int_max_str_digits()
+        sys.set_int_max_str_digits(4300)
+        try:
+            spec = SpecifierSet(specifier)
+            with pytest.raises(ValueError, match="Exceeds the limit"):
+                spec.contains("1.0")
+        finally:
+            sys.set_int_max_str_digits(old)
+
     @pytest.mark.parametrize(
         ("version", "specifier", "expected"),
         [

tests/test_version.py

@@ -213,6 +213,28 @@ def test_invalid_versions(self, version: str) -> None:
         with pytest.raises(InvalidVersion):
             Version(version)
 
+    @pytest.mark.skipif(
+        not hasattr(sys, "get_int_max_str_digits"),
+        reason="requires int max str digits limit",
+    )
+    @pytest.mark.parametrize(
+        "version",
+        [
+            # Simple path (digits only)
+            "1" * 5000,
+            # Regex path (has pre-release)
+            "1.0a" + "1" * 5000,
+        ],
+    )
+    def test_oversized_version_raises_valueerror(self, version: str) -> None:
+        old = sys.get_int_max_str_digits()
+        sys.set_int_max_str_digits(4300)
+        try:
+            with pytest.raises(ValueError, match="Exceeds the limit"):
+                Version(version)
+        finally:
+            sys.set_int_max_str_digits(old)
+
     @pytest.mark.parametrize(
         ("version", "normalized"),
         [