Skip to content

Commit 668da86

Browse files
authored
Rename format_full_version to _format_full_version to make it visibly private (#1125)
1 parent f294d52 commit 668da86

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/packaging/markers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ def _evaluate_markers(
284284
return any(all(item) for item in groups)
285285

286286

287-
def format_full_version(info: sys._version_info) -> str:
287+
def _format_full_version(info: sys._version_info) -> str:
288288
version = f"{info.major}.{info.minor}.{info.micro}"
289289
kind = info.releaselevel
290290
if kind != "final":
@@ -297,7 +297,7 @@ def default_environment() -> Environment:
297297
298298
This is the base environment used by :meth:`Marker.evaluate`.
299299
"""
300-
iver = format_full_version(sys.implementation.version)
300+
iver = _format_full_version(sys.implementation.version)
301301
implementation_name = sys.implementation.name
302302
return {
303303
"implementation_name": implementation_name,

tests/test_markers.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
InvalidMarker,
1919
Marker,
2020
UndefinedComparison,
21+
_format_full_version,
2122
default_environment,
22-
format_full_version,
2323
)
2424

2525
VARIABLES = [
@@ -160,11 +160,11 @@ def test_multidigit_minor_version(self, monkeypatch: pytest.MonkeyPatch) -> None
160160

161161
def tests_when_releaselevel_final(self) -> None:
162162
v = FakeVersionInfo(3, 4, 2, "final", 0)
163-
assert format_full_version(v) == "3.4.2" # type: ignore[arg-type]
163+
assert _format_full_version(v) == "3.4.2" # type: ignore[arg-type]
164164

165165
def tests_when_releaselevel_not_final(self) -> None:
166166
v = FakeVersionInfo(3, 4, 2, "beta", 4)
167-
assert format_full_version(v) == "3.4.2b4" # type: ignore[arg-type]
167+
assert _format_full_version(v) == "3.4.2b4" # type: ignore[arg-type]
168168

169169

170170
class TestMarker:

0 commit comments

Comments
 (0)