Fix OpenSSL issue#447
Merged
sigmavirus24 merged 2 commits intopypa:masterfrom Jan 30, 2019
Merged
Conversation
A [recent change](https://github.com/requests/toolbelt/compare/0.8.0..0.9.0) to requests-toolbelt results in twine attempting to reference the pyopenssl library when it is not a requirement. While this is addressed in requests-toolbelt, we should pin twine to the last working version.
Codecov Report
@@ Coverage Diff @@
## master #447 +/- ##
=======================================
Coverage 79.94% 79.94%
=======================================
Files 14 14
Lines 748 748
Branches 108 108
=======================================
Hits 598 598
Misses 113 113
Partials 37 37Continue to review full report at Codecov.
|
fergomrom
approved these changes
Jan 29, 2019
Contributor
Author
|
After some discussion in requests/toolbelt#241 and requests/toolbelt#242 now attempting a fix in |
Member
|
0.9.1 was released which should fix this. We'd need to cut a new release to fix the version constraints. If you accept the suggestion in-line then we can cut a release that just blacklists 0.9.0 and ensures no one accidentally gets that version |
Co-Authored-By: ryanwilsonperkin <ryanwilsonperkin@gmail.com>
Contributor
Author
|
Thanks for the suggestion @sigmavirus24, applied your fix |
jonathanmeier5
added a commit
to jonathanmeier5/compose-flow
that referenced
this pull request
Feb 19, 2019
Due to a bad release of requests-toolbelt 0.9.0 discussed here pypa/twine#447 twine was attempting to refrence pyopenssl when it was not actually installed. These upgrades fix the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #446
Using
twineto push a package to a repository over HTTPS recently began resulting in the following stack trace:A recent change to
requests-toolbeltresults in twine attempting to reference thepyopenssllibrary when it is not a requirement.While this is being addressed (requests/toolbelt#241) in
requests-toolbelt, we should pin twine to the last working version.