stubtest: Improve error message for __all__-related errors (#14362)

AlexWaygood · hauntsaninja · web-flow · commit 2c225659f3ae · 2022-12-28T19:23:44.000-06:00
This error is *only* emitted if `__all__` is included in the stub, so
the 'if present' clause is unnecessary

Co-authored-by: Shantanu &lt;12621235+hauntsaninja@users.noreply.github.com&gt;
diff --git a/mypy/stubtest.py b/mypy/stubtest.py
@@ -267,7 +267,7 @@ def _verify_exported_names(
         object_path + ["__all__"],
         (
             "names exported from the stub do not correspond to the names exported at runtime. "
-            "This is probably due to things being missing from the stub, or if present, an inaccurate `__all__` in the stub"
+            "This is probably due to things being missing from the stub or an inaccurate `__all__` in the stub"
         ),
         # Pass in MISSING instead of the stub and runtime objects, as the line numbers aren't very
         # relevant here, and it makes for a prettier error message

Original file line number	Diff line number	Diff line change
`@@ -267,7 +267,7 @@ def _verify_exported_names(`
`267`	`267`	`object_path + ["__all__"],`
`268`	`268`	`(`
`269`	`269`	`"names exported from the stub do not correspond to the names exported at runtime. "`
`270`		- "This is probably due to things being missing from the stub, or if present, an inaccurate `__all__` in the stub"
	`270`	+ "This is probably due to things being missing from the stub or an inaccurate `__all__` in the stub"
`271`	`271`	`),`
`272`	`272`	`# Pass in MISSING instead of the stub and runtime objects, as the line numbers aren't very`
`273`	`273`	`# relevant here, and it makes for a prettier error message`