Added optional parameter --nsubgenes#93
Conversation
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
|
I think the change that Gisela proposed needs to be also done in almost all other files (not in the R script though). |
Thanks for the reminder Daniel, I've made the changes to the other files as well, and tested the rerun on cluster with The pipeline completed successfully |
There was a problem hiding this comment.
Hi @jonoave ,
thanks for the changes, looks good to me now, I just have a minor comment. The failing tests are due to some updates that are needed in the CI workflows, etc. That can be fixed in a separate PR so don't worry about them...
|
Great, thanks for your contribution @jonoave , once the tests pass we can merge! |
Changed indentations, this should fix the Markdownlint error
Removed trailing whitespace, this should fix the EditorConfig error
Again removed trailing whitespace...
Trailing whitespace the third
Many thanks to contributing to qbic-pipelines!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist
This comment contains a description of changes (with reason)
Added optional parameter
--nsubgenes, due to potential errors with small dataset like miRNAshttps://www.biostars.org/p/456209/
If you've fixed a bug or added code that should be tested, add tests!
Ensure the test suite passes (
nextflow run . -profile test,docker).Tested with the following options, completed without errors:
docsis updatedNot updated.
CHANGELOG.mdis updatedUpdated with line on v 1.4.1
README.mdis updatedNot updated.
Learn more about contributing: https://github.com/qbic-pipelines/rnadeseq/tree/master/.github/CONTRIBUTING.md