Refactor security scan link visibility based on user permissions

Author: Xpirix

qgis-app/plugins/templates/plugins/plugin_detail.html

@@ -264,41 +264,40 @@ <h2>
                 </div>
                 <p class="plugin-details-description">{{ object.description|linebreaksbr }}</p>
                 <div id="rating"> (<span id="votes">{% firstof votes '0' %}</span>) {% trans "votes" %}&nbsp;<span id="loading" style="display:none">Loading...</span><span id="vote-message" style="display:none"></span></div>
-                {% if user.is_staff or user in object.editors %}
-                    <div>
+                <div>
                         {% with release=object.stable|default:object.experimental %}
                             {% if release %}
                                 {% with security_scan=release.security_scan %}
                                     {% if security_scan.overall_status == 'passed' %}
-                                        <a href="{{ release.get_absolute_url }}#security-tab" class="button is-small is-rounded is-success">
+                                        <a {% if user.is_staff or user in object.editors %}href="{{ release.get_absolute_url }}#security-tab"{% endif %} class="button is-small is-rounded is-success">
                                             <span class="icon is-small">
                                                 <i class="fas fa-shield-halved"></i>
                                             </span>
                                             <span>{% trans "Security scan passed (latest)" %}</span>
                                         </a>
                                     {% elif security_scan.overall_status == 'critical' %}
-                                        <a href="{{ release.get_absolute_url }}#security-tab" class="button is-small is-rounded is-danger">
+                                        <a {% if user.is_staff or user in object.editors %}href="{{ release.get_absolute_url }}#security-tab"{% endif %} class="button is-small is-rounded is-danger">
                                             <span class="icon is-small">
                                                 <i class="fas fa-triangle-exclamation"></i>
                                             </span>
                                             <span>{% trans "Security issue detected (latest)" %}</span>
                                         </a>
                                     {% elif security_scan.overall_status == 'warning' %}
-                                        <a href="{{ release.get_absolute_url }}#security-tab" class="button is-small is-rounded is-warning">
+                                        <a {% if user.is_staff or user in object.editors %}href="{{ release.get_absolute_url }}#security-tab"{% endif %} class="button is-small is-rounded is-warning">
                                             <span class="icon is-small">
                                                 <i class="fas fa-circle-exclamation"></i>
                                             </span>
                                             <span>{% trans "Potential security issue (latest)" %}</span>
                                         </a>
                                     {% elif security_scan.overall_status == 'info' %}
-                                        <a href="{{ release.get_absolute_url }}#security-tab" class="button is-small is-rounded is-info">
+                                        <a {% if user.is_staff or user in object.editors %}href="{{ release.get_absolute_url }}#security-tab"{% endif %} class="button is-small is-rounded is-info">
                                             <span class="icon is-small">
                                                 <i class="fas fa-info"></i>
                                             </span>
                                             <span>{% trans "Scanned with informational items (latest)" %}</span>
                                         </a>
                                     {% else %}
-                                        <a href="{{ release.get_absolute_url }}#security-tab" class="button is-small is-rounded is-light">
+                                        <a {% if user.is_staff or user in object.editors %}href="{{ release.get_absolute_url }}#security-tab"{% endif %} class="button is-small is-rounded is-light">
                                             <span class="icon is-small">
                                                 <i class="fas fa-circle-question"></i>
                                             </span>
@@ -309,7 +308,6 @@ <h2>
                             {% endif %}
                         {% endwith %}
                     </div>
-                {% endif %}
                 <a class="button mt-3" href="{% if object.stable %}{{ object.stable.get_download_url }}{% else %}{{ object.experimental.get_download_url }}{% endif %}">
                     <i class="fas fa-download" style="vertical-align: middle;"></i>&nbsp;{% trans "Download latest" %}
                 </a>