refactor(coverage): extract is_within_workspace to shared utility

- Add is_path_within_workspace function to utils.rs
- Remove wrapper methods and call utility directly from validate.rs and processor.rs
- Clean up unused Path imports

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: brynary

qlty-coverage/src/publish/processor.rs

@@ -1,8 +1,9 @@
 use crate::publish::{metrics::CoverageMetrics, Plan, Report, Results};
+use crate::utils::is_path_within_workspace;
 use anyhow::Result;
 use qlty_types::tests::v1::FileCoverage;
 use std::collections::HashSet;
-use std::path::{Path, PathBuf};
+use std::path::PathBuf;
 
 pub struct Processor {
     plan: Plan,
@@ -43,7 +44,7 @@ impl Processor {
                 let path = PathBuf::from(&file_coverage.path);
                 match path.try_exists() {
                     Ok(true) => {
-                        if !self.is_within_workspace(&path) {
+                        if !is_path_within_workspace(&path, self.plan.workspace_root.as_ref()) {
                             outside_workspace_files.insert(file_coverage.path.clone());
                             false
                         } else {
@@ -62,7 +63,7 @@ impl Processor {
                 let path = PathBuf::from(&file_coverage.path);
                 match path.try_exists() {
                     Ok(true) => {
-                        if !self.is_within_workspace(&path) {
+                        if !is_path_within_workspace(&path, self.plan.workspace_root.as_ref()) {
                             outside_workspace_files.insert(file_coverage.path.clone());
                         } else {
                             found_files.insert(file_coverage.path.clone());
@@ -92,17 +93,6 @@ impl Processor {
         })
     }
 
-    fn is_within_workspace(&self, file_path: &Path) -> bool {
-        let Some(ref workspace_root) = self.plan.workspace_root else {
-            return true;
-        };
-
-        match (file_path.canonicalize(), workspace_root.canonicalize()) {
-            (Ok(canonical_file), Ok(canonical_root)) => canonical_file.starts_with(&canonical_root),
-            _ => false,
-        }
-    }
-
     fn transform(&self, file_coverage: FileCoverage) -> Option<FileCoverage> {
         let mut file_coverage: Option<FileCoverage> = Some(file_coverage.clone());
 

qlty-coverage/src/utils.rs

@@ -1,8 +1,19 @@
 use crate::formats::Formats;
 use anyhow::Result;
-use std::path::PathBuf;
+use std::path::{Path, PathBuf};
 use std::str::FromStr;
 
+pub fn is_path_within_workspace(file_path: &Path, workspace_root: Option<&PathBuf>) -> bool {
+    let Some(workspace_root) = workspace_root else {
+        return true;
+    };
+
+    match (file_path.canonicalize(), workspace_root.canonicalize()) {
+        (Ok(canonical_file), Ok(canonical_root)) => canonical_file.starts_with(&canonical_root),
+        _ => false,
+    }
+}
+
 // Format specification priority:
 // 1. The format specified in the path, e.g.: simplecov:./coverage/coverage.json
 // 2. The format specified in the command line arguments, through --report-format simplecov

qlty-coverage/src/validate.rs

@@ -1,8 +1,9 @@
 use anyhow::Result;
 use serde::Serialize;
-use std::path::{Path, PathBuf};
+use std::path::PathBuf;
 
 use crate::publish::Report;
+use crate::utils::is_path_within_workspace;
 
 const DEFAULT_THRESHOLD: f64 = 90.0;
 
@@ -46,7 +47,7 @@ impl Validator {
                 return;
             }
 
-            if !self.is_within_workspace(&path) {
+            if !is_path_within_workspace(&path, self.workspace_root.as_ref()) {
                 validation_result.files_outside_workspace += 1;
                 return;
             }
@@ -74,17 +75,6 @@ impl Validator {
 
         Ok(validation_result)
     }
-
-    fn is_within_workspace(&self, file_path: &Path) -> bool {
-        let Some(ref workspace_root) = self.workspace_root else {
-            return true;
-        };
-
-        match (file_path.canonicalize(), workspace_root.canonicalize()) {
-            (Ok(canonical_file), Ok(canonical_root)) => canonical_file.starts_with(&canonical_root),
-            _ => false,
-        }
-    }
 }
 
 #[derive(Debug, Clone, Serialize, Default, PartialEq)]