fix(workflows): allow 'tmp' in for_each and expose metadata.depth for templates

ibacalu · ibacalu · commit 901d142b093c · 2025-12-01T16:28:22.000+02:00
Add 'tmp' as an allowed per-iteration key in the workflow schema, move where exec context exposes depth so templates can access it via metadata.depth, and update workflow-creator templates to reference metadata.depth and include a workspace path. These changes fix variable scoping in templates and enable use of temporary loop variables.
diff --git a/src/workflows_mcp/engine/schema.py b/src/workflows_mcp/engine/schema.py
@@ -834,7 +834,7 @@ def validate_string_value(value: str, context: str, allow_each: bool = False) ->
                         f"{context}: Invalid variable reference '{{{{{var_path}}}}}'. "
                         f"Unknown namespace '{parts[0]}'. "
                         f"Valid namespaces: 'inputs', 'blocks', 'metadata', 'secrets', "
-                        f"'each' (for_each blocks only)"
+                        f"'tmp', 'each' (for_each blocks only)"
                     )
 
         def check_dict_values(obj: Any, path: str, allow_each: bool = False) -> None:
diff --git a/src/workflows_mcp/engine/workflow_runner.py b/src/workflows_mcp/engine/workflow_runner.py
@@ -1038,6 +1038,7 @@ def _create_initial_execution_context(
             "started_at": workflow_start_time,
             "execution_id": execution_id,
             "scratch_dir": str(scratch_dir),
+            "depth": exec_context.depth,
         }
 
         if context:
@@ -1108,7 +1109,6 @@ def _execution_to_dict(self, exec_context: Execution) -> dict[str, Any]:
             "metadata": metadata,
             "blocks": blocks,
             "tmp": str(exec_context.scratch_dir) if exec_context.scratch_dir else "",
-            "depth": exec_context.depth,
         }
 
     async def _evaluate_condition(self, condition: str, exec_context: Execution) -> bool:
diff --git a/src/workflows_mcp/templates/agents/workflow-creator/layer2/design-approval-loop.yaml b/src/workflows_mcp/templates/agents/workflow-creator/layer2/design-approval-loop.yaml
@@ -83,7 +83,7 @@ blocks:
         {{inputs.examples}}
         </examples>
 
-        {% if depth == 1 %}
+        {% if metadata.depth == 1 %}
         # Design New Workflow
 
         Create a Mermaid flowchart diagram for this workflow:
@@ -104,7 +104,7 @@ blocks:
 
         Generate the initial design now.
         {% else %}
-        # Refine Workflow Design (Iteration {{depth}})
+        # Refine Workflow Design (Iteration {{metadata.depth}})
 
         ## Current Design
         <previous_diagram>
@@ -175,14 +175,14 @@ blocks:
     type: CreateFile
     depends_on: [generate_diagram]
     inputs:
-      path: "{{inputs.workspace}}/diagram-{{depth}}.html"
+      path: "{{inputs.workspace}}/diagram-{{metadata.depth}}.html"
       create_parents: true
       overwrite: true
       content: |
         <!DOCTYPE html>
         <html>
         <head>
-          <title>Workflow Design - Iteration {{depth}}</title>
+          <title>Workflow Design - Iteration {{metadata.depth}}</title>
           <script type="module">
             import mermaid from 'https://cdn.jsdelivr.net/npm/mermaid@11/dist/mermaid.esm.min.mjs';
             mermaid.initialize({ startOnLoad: true, theme: 'default' });
@@ -196,7 +196,7 @@ blocks:
         </head>
         <body>
           <h1>Workflow Design</h1>
-          <p class="subtitle">Iteration {{depth}}</p>
+          <p class="subtitle">Iteration {{metadata.depth}}</p>
           <div class="mermaid">
         {{blocks.generate_diagram.outputs.response.mermaid_diagram}}
           </div>
@@ -209,10 +209,10 @@ blocks:
     depends_on: [create_diagram_viewer]
     inputs:
       prompt: |
-        # WORKFLOW DESIGN - ITERATION {{depth}}
-        {% if depth > 10 %}
+        # WORKFLOW DESIGN - ITERATION {{metadata.depth}}
+        {% if metadata.depth > 10 %}
 
-        ⚠️ You've made {{depth}} refinements. This is getting expensive. Max depth is 50.
+        ⚠️ You've made {{metadata.depth}} refinements. This is getting expensive. Max depth is 50.
         {% endif %}
 
         ## Diagram
diff --git a/src/workflows_mcp/templates/agents/workflow-creator/workflow-creator.yaml b/src/workflows_mcp/templates/agents/workflow-creator/workflow-creator.yaml
@@ -214,6 +214,7 @@ blocks:
         requirements: "{{inputs.workspace}}/requirements.json"
         executor_docs: "{{blocks.bootstrap_context.outputs.executor_docs}}"
         examples: "{{blocks.bootstrap_context.outputs.examples}}"
+        workspace: "{{inputs.workspace}}/design-approval"
   
   - id: check_design_approval
     depends_on: [design_approval]

Original file line number	Diff line number	Diff line change
`@@ -834,7 +834,7 @@ def validate_string_value(value: str, context: str, allow_each: bool = False) ->`
`834`	`834`	`f"{context}: Invalid variable reference '{{{{{var_path}}}}}'. "`
`835`	`835`	`f"Unknown namespace '{parts[0]}'. "`
`836`	`836`	`f"Valid namespaces: 'inputs', 'blocks', 'metadata', 'secrets', "`
`837`		`- f"'each' (for_each blocks only)"`
	`837`	`+ f"'tmp', 'each' (for_each blocks only)"`
`838`	`838`	`)`
`839`	`839`
`840`	`840`	`def check_dict_values(obj: Any, path: str, allow_each: bool = False) -> None:`
Original file line number	Diff line number	Diff line change
`@@ -1038,6 +1038,7 @@ def _create_initial_execution_context(`
`1038`	`1038`	`"started_at": workflow_start_time,`
`1039`	`1039`	`"execution_id": execution_id,`
`1040`	`1040`	`"scratch_dir": str(scratch_dir),`
	`1041`	`+ "depth": exec_context.depth,`
`1041`	`1042`	`}`
`1042`	`1043`
`1043`	`1044`	`if context:`
`@@ -1108,7 +1109,6 @@ def _execution_to_dict(self, exec_context: Execution) -> dict[str, Any]:`
`1108`	`1109`	`"metadata": metadata,`
`1109`	`1110`	`"blocks": blocks,`
`1110`	`1111`	`"tmp": str(exec_context.scratch_dir) if exec_context.scratch_dir else "",`
`1111`		`- "depth": exec_context.depth,`
`1112`	`1112`	`}`
`1113`	`1113`
`1114`	`1114`	`async def _evaluate_condition(self, condition: str, exec_context: Execution) -> bool:`