fix(git): fix boolean expression syntax and shell expansion issues

Fixed two issues in git workflows:

1. git-analyze-changes: Split boolean expression into separate variable
   references to enable proper variable resolution and evaluation

2. git-commit: Replace echo with printf to prevent shell expansion of
   special characters in commit messages

Author: ibacalu

src/workflows_mcp/templates/git/git-analyze-changes.yaml

@@ -10,68 +10,102 @@ inputs:
     default: "."
     required: false
 
+  staged_only:
+    type: bool
+    description: If true, only analyze staged changes (default). Set false to include unstaged/untracked.
+    default: true
+    required: false
+
 blocks:
-  - id: changes
+  - id: get_staged_summary
     type: Shell
+    description: "Get diff statistics for staged changes"
     inputs:
-      command: |
-        # Check for any changes: staged, unstaged, or untracked
-        if [ -z "$(git status --porcelain)" ]; then
-          printf "false" > $SCRATCH/changes.txt
-        else
-          printf "true" > $SCRATCH/changes.txt
-        fi
+      command: git diff --cached --stat --compact-summary > $SCRATCH/summary.txt
       working_dir: "${inputs.working_dir}"
-    outputs:
-      detected:
-        type: bool
-        description: "Indicates if there are any changes (staged, unstaged, or untracked)"
-        path: "$SCRATCH/changes.txt"
+    condition: "${inputs.staged_only}"
 
-  - id: get_file_status
+  - id: get_staged_diff
     type: Shell
+    description: "Generate compact diff of staged changes"
     inputs:
-      command: git status --short --porcelain
+      command: git diff --cached -U0 --inter-hunk-context=0 --no-color --no-prefix > $SCRATCH/raw_diff.txt
       working_dir: "${inputs.working_dir}"
-    condition: ${blocks.changes.outputs.detected}
-    depends_on:
-      - changes
+    condition: "${inputs.staged_only}"
 
-  - id: get_staged_diff
+  - id: get_all_summary
     type: Shell
+    description: "Get diff statistics for all changes (staged + unstaged)"
     inputs:
-      command: git diff --cached
+      command: git diff HEAD --stat --compact-summary > $SCRATCH/summary.txt
       working_dir: "${inputs.working_dir}"
-    condition: ${blocks.changes.outputs.detected}
-    depends_on:
-      - changes
+    condition: "not ${inputs.staged_only}"
 
-  - id: get_unstaged_diff
+  - id: get_all_diff
     type: Shell
+    description: "Generate compact diff of all changes (staged + unstaged)"
     inputs:
-      command: git diff
+      command: |
+        git diff HEAD -U0 --inter-hunk-context=0 --no-color --no-prefix > $SCRATCH/raw_diff.txt
       working_dir: "${inputs.working_dir}"
-    condition: ${blocks.changes.outputs.detected}
-    depends_on:
-      - changes
+    condition: "not ${inputs.staged_only}"
 
-  - id: get_diff_stat
+  - id: processing
     type: Shell
+    description: "Process and consolidate analysis results"
     inputs:
       command: |
-        echo "=== Staged Changes ==="
-        git diff --cached --stat || echo "No staged changes"
-        echo ""
-        echo "=== Unstaged Changes ==="
-        git diff --stat || echo "No unstaged changes"
+        MAX_LINES=40
+
+        # Process raw diff with line limiting
+        if [ -f "$SCRATCH/raw_diff.txt" ]; then
+          awk -v max="$MAX_LINES" '
+          BEGIN { lines = 0; truncated = 0 }
+          /^diff --git/ {
+            if (truncated) {
+              print "    ... (truncated " truncated " lines)\n"
+            }
+            lines = 0
+            truncated = 0
+            print
+            next
+          }
+          {
+            if (lines < max) {
+              print
+              lines++
+            } else {
+              truncated++
+            }
+          }
+          END {
+            if (truncated) {
+              print "    ... (truncated " truncated " lines)"
+            }
+          }
+          ' "$SCRATCH/raw_diff.txt" > "$SCRATCH/processed_diff.txt"
+        else
+          touch "$SCRATCH/processed_diff.txt"
+        fi
       working_dir: "${inputs.working_dir}"
-    condition: ${blocks.changes.outputs.detected}
     depends_on:
-      - changes
+      - block: get_staged_summary
+        required: false
+      - block: get_staged_diff
+        required: false
+      - block: get_all_summary
+        required: false
+      - block: get_all_diff
+        required: false
+    outputs:
+      summary:
+        type: str
+        path: "$SCRATCH/summary.txt"
+      diff:
+        type: str
+        path: "$SCRATCH/processed_diff.txt"
 
 outputs:
-  has_changes: "${blocks.changes.outputs.detected}"
-  file_status: "${blocks.get_file_status.outputs.stdout}"
-  staged_diff: "${blocks.get_staged_diff.outputs.stdout}"
-  unstaged_diff: "${blocks.get_unstaged_diff.outputs.stdout}"
-  diff_stat: "${blocks.get_diff_stat.outputs.stdout}"
+  has_changes: "${blocks.get_staged_diff.succeeded} or ${blocks.get_all_diff.succeeded}"
+  summary: "${blocks.processing.outputs.summary}"
+  diff: "${blocks.processing.outputs.diff}"

src/workflows_mcp/templates/git/git-commit.yaml

@@ -95,14 +95,11 @@ blocks:
         - Body: explain what and why (optional)
         - Scope: component/module affected (optional)
 
-        ## File Status
-        ${blocks.analyze_changes.outputs.file_status}
-
-        ## Diff Statistics
-        ${blocks.analyze_changes.outputs.diff_stat}
+        ## Summary
+        ${blocks.analyze_changes.outputs.summary}
 
         ## Detailed Changes
-        ${blocks.analyze_changes.outputs.staged_diff}
+        ${blocks.analyze_changes.outputs.diff}
 
         Generate ONLY the commit message (no quotes, no explanations):
     condition: "${blocks.analyze_changes.outputs.has_changes} and ${inputs.commit_message} == ''"
@@ -116,10 +113,10 @@ blocks:
       command: |
         if [ -n "${inputs.commit_message}" ]; then
           # Use manual message if provided
-          echo "${inputs.commit_message}"
+          printf '%s\n' "${inputs.commit_message}"
         else
-          # Use LLM-generated message
-          echo "${blocks.llm_generate_message.outputs.response}"
+          # Use LLM-generated message (printf prevents shell expansion of special chars)
+          printf '%s\n' "${blocks.llm_generate_message.outputs.response}"
         fi
     condition: "${blocks.analyze_changes.outputs.has_changes}"
     depends_on:
@@ -147,7 +144,7 @@ blocks:
       command: |
         set -e  # Exit immediately if any command fails
         # Create commit and get hash (using -F - to handle multi-line messages)
-        echo "${blocks.select_message.outputs.stdout}" | git commit -F -
+        printf '%s' "${blocks.select_message.outputs.stdout}" | git commit -F -
         git rev-parse HEAD
       working_dir: "${inputs.working_dir}"
     condition: "${blocks.analyze_changes.outputs.has_changes} and (${inputs.auto_commit} or ${blocks.confirm_commit.outputs.response} == 'yes')"