Skip to content

Commit 9f3abb6

Browse files
committed
Problems panel: add an icon per problem to tell which type it is (adobe#13430)
1 parent 09c7211 commit 9f3abb6

2 files changed

Lines changed: 28 additions & 1 deletion

File tree

src/htmlContent/problems-panel-table.html

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<tbody>
33
{{#reportList}}
44
<tr class="inspector-section">
5-
<td colspan="3">
5+
<td colspan="4">
66
<span class="disclosure-triangle {{#isExpanded}}expanded{{/isExpanded}}"></span>
77
<input type="hidden" value="{{providerName}}" />
88
{{providerName}} ({{results.length}})
@@ -11,6 +11,9 @@
1111
{{#results}}
1212
<tr class="{{display}}">
1313
<td class="line-number" data-character="{{pos.ch}}">{{friendlyLine}}</td>
14+
<td class="line-icon">
15+
<div class="line-icon-default line-icon-{{type}}"></div>
16+
</td>
1417
<td class="line-text">{{message}}</td>
1518
<td class="line-snippet">{{codeSnippet}}</td>
1619
</tr>

src/styles/brackets.less

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2108,9 +2108,33 @@ textarea.exclusions-editor {
21082108
text-align: right; // make line number line up with editor line numbers
21092109
}
21102110

2111+
.line-icon {
2112+
vertical-align: middle;
2113+
2114+
.line-icon-default {
2115+
width: 20px;
2116+
height: 18px;
2117+
background-image: url(images/topcoat-inactive-15.svg);
2118+
background-repeat: no-repeat;
2119+
background-position: 0px 1px;
2120+
}
2121+
2122+
// Add an image based on the type of the problem.
2123+
.line-icon-problem_type_error {
2124+
background-image: url(images/topcoat-error-15.svg);
2125+
}
2126+
.line-icon-problem_type_warning {
2127+
background-image: url(images/topcoat-warning-15.svg);
2128+
}
2129+
.line-icon-problem_type_meta {
2130+
background-image: url(images/topcoat-inactive-15.svg);
2131+
}
2132+
}
2133+
21112134
.line-text {
21122135
white-space: nowrap;
21132136
width: auto;
2137+
padding-left: 5px;
21142138
}
21152139

21162140
.line-snippet {

0 commit comments

Comments
 (0)