Skip to content

Commit 9716c8d

Browse files
javedabsar1mabsar
andauthored
[hexagon-mlir][scripts] Clean up build scripts. (#70)
original patch from Zachary Zipper. Signed-off-by: mabsar <mabsar@qti.qualcommm.com> Co-authored-by: mabsar <mabsar@qti.qualcommm.com>
1 parent 93ade94 commit 9716c8d

4 files changed

Lines changed: 12 additions & 11 deletions

File tree

.gitmodules

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[submodule "triton"]
2-
path = triton
3-
url = https://github.com/triton-lang/triton.git
2+
path = triton
3+
url = https://github.com/triton-lang/triton.git
44
[submodule "triton_shared"]
5-
path = triton_shared
6-
url = https://github.com/facebookincubator/triton-shared.git
5+
path = triton_shared
6+
url = https://github.com/facebookincubator/triton-shared.git

ci/setup_submodules.sh

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ REPO_ROOT="$(git rev-parse --show-toplevel)"
1212
echo "Configuring git submodules"
1313
cd "${REPO_ROOT}"
1414

15-
# Ensure existing submodules are initialized
16-
git submodule update --init
1715

1816
add_and_checkout() {
1917
local name="$1"
@@ -22,8 +20,8 @@ add_and_checkout() {
2220

2321
cd "${REPO_ROOT}"
2422
if [ ! -d "${REPO_ROOT}/${name}" ]; then
25-
echo "Adding submodule ${name}"
26-
git submodule add --force "${url}" "${name}"
23+
echo "Cloning ${name}"
24+
git clone "${url}" "${name}"
2725
fi
2826

2927
echo "Checking out ${name} at ${commit}"

scripts/build_hexagon_mlir.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
# https://github.com/qualcomm/hexagon-mlir/LICENSE.txt
77
#
88
set -euo pipefail
9-
set -e
109

1110
echo "----------------------------------------------------"
1211
echo "Welcome to hexagon-mlir local building script .. "
@@ -192,3 +191,5 @@ else
192191
echo "Triton build missing; skipping tests."
193192
fi
194193
echo "Local build script completed successfully."
194+
195+
set +euo pipefail

scripts/set_local_env.sh

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
# For more license information:
66
# https://github.com/qualcomm/hexagon-mlir/LICENSE.txt
77
#
8-
set -euo pipefail
9-
set -x
8+
9+
set -euxo pipefail
1010

1111
export HEXAGON_MLIR_ROOT=$PWD
1212
export TRITON_ROOT=$PWD/triton
@@ -30,3 +30,5 @@ export TRITON_HOME=$HEXAGON_MLIR_ROOT
3030
export TRITON_PLUGIN_DIRS="$HEXAGON_MLIR_ROOT/triton_shared;$HEXAGON_MLIR_ROOT/qcom_hexagon_backend"
3131
export PATH=$TRITON_ROOT/build/cmake.linux-x86_64-cpython-${PYTHON_VERSION}/third_party/qcom_hexagon_backend/bin/:$TRITON_ROOT/build/cmake.linux-x86_64-cpython-${PYTHON_VERSION}/third_party/triton_shared/tools/triton-shared-opt:$PATH
3232
export PYTHONPATH=$TRITON_ROOT/python:${PYTHONPATH:-}
33+
34+
set +euxo pipefail

0 commit comments

Comments
 (0)